Supervised users: Slightly relax restrictions around extensions.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 /**
  * The type of the extension data object. The definition is based on
  * chrome/browser/ui/webui/extensions/extension_basic_info.cc
  * and
@@ skipping 11 matching lines @@
  *            enable_show_button: boolean,
  *            enabled: boolean,
  *            enabledIncognito: boolean,
  *            errorCollectionEnabled: (boolean|undefined),
  *            hasPopupAction: boolean,
  *            homepageProvided: boolean,
  *            homepageUrl: string,
  *            icon: string,
  *            id: string,
  *            incognitoCanBeEnabled: boolean,
+ *            installedByCustodian: boolean,
  *            installWarnings: (Array|undefined),
  *            is_hosted_app: boolean,
  *            is_platform_app: boolean,
  *            isFromStore: boolean,
  *            isUnpacked: boolean,
  *            kioskEnabled: boolean,
  *            kioskOnly: boolean,
  *            locationText: string,
  *            managedInstall: boolean,
  *            manifestErrors: (Array.<RuntimeError>|undefined),
@@ skipping 307 matching lines @@
       } else if (extension.corruptInstall && extension.isFromStore) {
         var repair = node.querySelector('.corrupted-repair-button');
         repair.hidden = false;
         repair.onclick = function() {
           chrome.send('extensionSettingsRepair', [extension.id]);
         };
       } else {
         // The 'Enabled' checkbox.
         var enable = node.querySelector('.enable-checkbox');
         enable.hidden = false;
         var enableCheckboxDisabled = extension.managedInstall ||

[Pam (message me for reviews), 2015/02/23 10:18:50]

Maintainability = ick. Can we get most of this from UserMayModifySettings?

[Marc Treib, 2015/02/23 12:07:38]

Agreed re maintainability, but I don't see a better way.

I removed SupervisedUserService::UserMayModifySettings because that means the
extension can never be disabled, even if it requires new permissions. (The
"User" in the name is misleading :-/)

                                      extension.suspiciousInstall ||
                                      extension.corruptInstall ||
                                      extension.updateRequiredByPolicy ||
+                                     extension.installedByCustodian ||
                                      extension.dependentExtensions.length > 0;
         enable.querySelector('input').disabled = enableCheckboxDisabled;
 
         if (extension.managedInstall) {
           var indicator = new cr.ui.ControlledIndicator();
           indicator.classList.add('controlled-extension-indicator');
           indicator.setAttribute('controlled-by', 'policy');
           var textPolicy = extension.policyText || '';
           indicator.setAttribute('textpolicy', textPolicy);
           indicator.image.setAttribute('aria-label', textPolicy);
@@ skipping 218 matching lines @@
       // TODO(dbeam): why do we need to focus <extensionoptions> before and
       // after its showing animation? Makes very little sense to me.
       overlay.setInitialFocus();
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });