Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 925523003: DM: move ext into key (Closed)

Created:
5 years, 10 months ago by mtklein_C
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : now, options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dm/DMJsonWriter.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925523003/1
5 years, 10 months ago (2015-02-12 15:13:44 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-12 15:13:44 UTC) #3
mtklein_C
5 years, 10 months ago (2015-02-12 15:15:13 UTC) #6
stephana
On 2015/02/12 15:15:13, mtklein_C wrote: lgtm
5 years, 10 months ago (2015-02-12 15:17:28 UTC) #7
jcgregorio
lgtm
5 years, 10 months ago (2015-02-12 15:28:05 UTC) #8
mtklein
PTAL. ext now goes under options.
5 years, 10 months ago (2015-02-12 21:05:39 UTC) #11
mtklein
OK.. going to land this to get unblocked on the ingester-side of the change. "ext" ...
5 years, 10 months ago (2015-02-17 21:10:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925523003/20001
5 years, 10 months ago (2015-02-17 21:11:34 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 21:18:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/82079fb7aaf000591300e0662301594901d56d06

Powered by Google App Engine
This is Rietveld 408576698