Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 925433002: Make it possible to define arguments for CompileFunctionInContext (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Yang
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make it possible to define arguments for CompileFunctionInContext Also make sure that the function body really produces only one function literal. LOG=y BUG=none R=yangguo@chromium.org Committed: https://crrev.com/58deea0ad05147ff6a5789b55a6f29315d0630d6 Cr-Commit-Position: refs/heads/master@{#26617}

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -8 lines) Patch
M include/v8.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/api.cc View 1 2 2 chunks +103 lines, -5 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 3 chunks +57 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
ptal
5 years, 10 months ago (2015-02-12 13:23:56 UTC) #1
Yang
lgtm. https://codereview.chromium.org/925433002/diff/20001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/925433002/diff/20001/src/api.cc#newcode1772 src/api.cc:1772: has_pending_exception = result.is_null(); You could avoid a redundant ...
5 years, 10 months ago (2015-02-12 13:54:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925433002/40001
5 years, 10 months ago (2015-02-12 13:59:48 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-12 14:38:59 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 14:39:13 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/58deea0ad05147ff6a5789b55a6f29315d0630d6
Cr-Commit-Position: refs/heads/master@{#26617}

Powered by Google App Engine
This is Rietveld 408576698