Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 925423002: Initialize the application context prior to initializing command line flags. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, ppi
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-stable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize the application context prior to initializing command line flags. We used to initialize the command line flags prior to setting the application context in Android's BrowserStartupController. When determining the command line flags for the renderer, certain flags may be dependent on the Android SDK version being used. Getting this value through base::android::BuildInfo requires the application context to be known. This change makes sure that we initialize the application context prior to calling the native SetCommandLineFlags function. BUG= Committed: https://crrev.com/5335d2564facbeea5368cfb188a0339e4699d71e Cr-Commit-Position: refs/heads/master@{#316565}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/BrowserStartupController.java View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
Peter Beverloo
The use of application context is being introduced here: https://codereview.chromium.org/914373003/ (see content_startup_flags.cc)
5 years, 10 months ago (2015-02-16 16:32:56 UTC) #1
Peter Beverloo
+nyquist for review +rmcilroy, ppi for fyi Who would be the appropriate reviewer for this? ...
5 years, 10 months ago (2015-02-16 17:42:59 UTC) #3
ppi
lgtm, sounds reasonable
5 years, 10 months ago (2015-02-16 17:55:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925423002/20001
5 years, 10 months ago (2015-02-16 17:57:57 UTC) #6
Miguel Garcia
lgtm
5 years, 10 months ago (2015-02-16 18:00:40 UTC) #8
rmcilroy
On 2015/02/16 18:00:40, Miguel Garcia wrote: > lgtm lgtm.
5 years, 10 months ago (2015-02-16 18:01:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43050)
5 years, 10 months ago (2015-02-16 18:03:21 UTC) #11
Peter Beverloo
On 2015/02/16 18:03:21, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-16 18:06:10 UTC) #12
Peter Beverloo
+tedchoc@chromium.org for OWNERS
5 years, 10 months ago (2015-02-16 18:06:50 UTC) #14
benm (inactive)
lgtm owners stamp
5 years, 10 months ago (2015-02-17 12:18:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925423002/20001
5 years, 10 months ago (2015-02-17 12:19:32 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 12:22:26 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 12:23:18 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5335d2564facbeea5368cfb188a0339e4699d71e
Cr-Commit-Position: refs/heads/master@{#316565}

Powered by Google App Engine
This is Rietveld 408576698