Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1974)

Issue 925373002: Test StringLengthStub generation via TurboFan. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Test StringLengthStub generation via TurboFan. For now we just use the RawMachineAssembler, this will be changed later to use the whole TurboFan pipeline. Committed: https://crrev.com/5d4c76eae72a5eae3475c2db79beaa3de962c44b Cr-Commit-Position: refs/heads/master@{#26902}

Patch Set 1 #

Total comments: 1

Patch Set 2 : cctest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M test/cctest/cctest.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/compiler/test-run-stubs.cc View 1 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Sven Panne
5 years, 10 months ago (2015-02-16 14:04:57 UTC) #2
titzer
Looks good for an initial experiment, although this change makes V8 require turbofan to generate ...
5 years, 10 months ago (2015-02-17 11:46:46 UTC) #3
Sven Panne
5 years, 10 months ago (2015-02-26 14:32:45 UTC) #5
dcarney
lgtm
5 years, 10 months ago (2015-02-26 14:41:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925373002/20001
5 years, 10 months ago (2015-02-27 06:55:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-27 06:56:50 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-27 06:57:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d4c76eae72a5eae3475c2db79beaa3de962c44b
Cr-Commit-Position: refs/heads/master@{#26902}

Powered by Google App Engine
This is Rietveld 408576698