Cleanup AstGraphBuilder::AddHomeObjectIfNeeded a bit.

Cleanup AstGraphBuilder::AddHomeObjectIfNeeded a bit.

R=rossberg@chromium.org

Committed: https://crrev.com/b82a49e6fb1a91b01cc691715c17b307c0ad2fc6
Cr-Commit-Position: refs/heads/master@{#26677}

[Michael Starzinger, 2015-02-16 18:56:27]

mstarzinger@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-02-16 20:09:56]

LGTM. Thanks.

https://codereview.chromium.org/925363003/diff/1/src/compiler/ast-graph-build...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/925363003/diff/1/src/compiler/ast-graph-build...
src/compiler/ast-graph-builder.cc:2810: return store;
What is the return value used for here?

[Michael Starzinger, 2015-02-16 20:30:35]

https://codereview.chromium.org/925363003/diff/1/src/compiler/ast-graph-build...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/925363003/diff/1/src/compiler/ast-graph-build...
src/compiler/ast-graph-builder.cc:2810: return store;
On 2015/02/16 20:09:56, arv wrote:
> What is the return value used for here?

It's not used, but for symmetry all builder methods return what they are
building. There are similar builder methods (e.g. BuildVariableAssignment) where
this is the case as well.

The main purpose of the naming behind the "BuildFoo" methods is to clearly
distinguish them from the "VisitFoo" family of methods, which return values via
the environment (and hence mutate the environment).

[arv (Not doing code reviews), 2015-02-16 20:41:53]

On 2015/02/16 20:30:35, Michael Starzinger wrote:
>
https://codereview.chromium.org/925363003/diff/1/src/compiler/ast-graph-build...
> File src/compiler/ast-graph-builder.cc (right):
> 
>
https://codereview.chromium.org/925363003/diff/1/src/compiler/ast-graph-build...
> src/compiler/ast-graph-builder.cc:2810: return store;
> On 2015/02/16 20:09:56, arv wrote:
> > What is the return value used for here?
> 
> It's not used, but for symmetry all builder methods return what they are
> building. There are similar builder methods (e.g. BuildVariableAssignment)
where
> this is the case as well.
> 
> The main purpose of the naming behind the "BuildFoo" methods is to clearly
> distinguish them from the "VisitFoo" family of methods, which return values
via
> the environment (and hence mutate the environment).

Thanks. That makes sense.

[Michael Starzinger, 2015-02-16 21:17:28]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-02-16 21:17:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/925363003/1

[commit-bot: I haz the power, 2015-02-16 21:18:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-16 21:19:19]

Patchset 1 (id:??) landed as
https://crrev.com/b82a49e6fb1a91b01cc691715c17b307c0ad2fc6
Cr-Commit-Position: refs/heads/master@{#26677}

[rossberg, 2015-02-17 07:14:01]

lgtm