Make commit for swap promises do not set can_cancel_commit.

Make commit for swap promises do not unset can_cancel_commit.

When swap promises are enqueued we request a commit. If there
are no updates the promises should be broken and the commit
skipped (EarlyOut_NoUpdates). To achieve that we request
the commit by calling SetNeedsUpdateLayers instead of
SetNeedsCommit in order to not unset can_cancel_commit. Note
that SetNeedsUpdateLayers is a subset of SetNeedsCommit and a
no-op when a commit has already been requested.

BUG=458577
Committed: https://crrev.com/eab34cc80772373eac0df3b6003fe1eeaf767d78
Cr-Commit-Position: refs/heads/master@{#317292}

[Ignacio Solla, 2015-02-16 12:29:10]

igsolla@chromium.org changed reviewers:
+ jam@chromium.org, skyostil@chromium.org

[Sami, 2015-02-16 16:11:48]

skyostil@chromium.org changed reviewers:
+ boliu@chromium.org

[Sami, 2015-02-16 16:12:30]

lgtm. +boliu FYI.

https://codereview.chromium.org/925353002/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/925353002/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:1455: compositor_->SetNeedsUpdateLayers();
Could you add a comment here saying why we need to UpdateLayers instead of
requesting a commit?

[Ignacio Solla, 2015-02-17 11:40:04]

New patchsets have been uploaded after l-g-t-m from skyostil@chromium.org

[Ignacio Solla, 2015-02-17 11:41:18]

https://codereview.chromium.org/925353002/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/925353002/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:1455: compositor_->SetNeedsUpdateLayers();
On 2015/02/16 16:12:30, Sami wrote:
> Could you add a comment here saying why we need to UpdateLayers instead of
> requesting a commit?

Done.

[jam, 2015-02-17 16:56:03]

please send this to an owner who knows this code better than me. looking through
content/OWNERs, I see sievers/piman as folks who're much more familiar with the
compositor code.

[Ignacio Solla, 2015-02-17 17:01:57]

igsolla@chromium.org changed reviewers:
+ piman@chromium.org, sievers@chromium.org
- jam@chromium.org

[piman, 2015-02-19 23:26:42]

lgtm

[Ignacio Solla, 2015-02-20 10:39:30]

The CQ bit was checked by igsolla@chromium.org

[commit-bot: I haz the power, 2015-02-20 10:44:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/925353002/20001

[commit-bot: I haz the power, 2015-02-20 11:33:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-20 11:34:16]

Patchset 2 (id:??) landed as
https://crrev.com/eab34cc80772373eac0df3b6003fe1eeaf767d78
Cr-Commit-Position: refs/heads/master@{#317292}