Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 925343003: use common impl for drawTextOnPath (Closed)

Created:
5 years, 10 months ago by reed2
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use common impl for drawTextOnPath BUG=skia: Committed: https://skia.googlesource.com/skia/+/f87fe78bc36c94143625fc38cc848d0da86eb60d

Patch Set 1 #

Total comments: 2

Patch Set 2 : move includes to the top #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -181 lines) Patch
M include/core/SkBitmapDevice.h View 1 chunk +0 lines, -3 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +2 lines, -3 lines 0 comments Download
M include/core/SkDraw.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/pdf/SkPDFDevice.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 chunks +126 lines, -0 lines 3 comments Download
M src/core/SkDraw.cpp View 1 chunk +0 lines, -129 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/pdf/SkPDFDeviceFlattener.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/pdf/SkPDFDeviceFlattener.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925343003/1
5 years, 10 months ago (2015-02-16 22:28:06 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-16 22:28:07 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 10 months ago (2015-02-17 04:28:07 UTC) #5
reed2
ptal
5 years, 10 months ago (2015-02-17 14:32:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925343003/1
5 years, 10 months ago (2015-02-17 14:32:56 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-17 14:32:57 UTC) #10
f(malita)
lgtm Does this clash with https://codereview.chromium.org/933483002/?
5 years, 10 months ago (2015-02-17 15:56:48 UTC) #12
hal.canary
PDF:lgtm https://codereview.chromium.org/925343003/diff/1/src/core/SkDevice.cpp File src/core/SkDevice.cpp (right): https://codereview.chromium.org/925343003/diff/1/src/core/SkDevice.cpp#newcode218 src/core/SkDevice.cpp:218: #include "SkTextToPathIter.h" you can move these to the ...
5 years, 10 months ago (2015-02-17 15:57:21 UTC) #13
reed2
On 2015/02/17 15:56:48, f(malita) wrote: > lgtm > > Does this clash with https://codereview.chromium.org/933483002/ Indeed ...
5 years, 10 months ago (2015-02-17 18:24:28 UTC) #14
reed2
https://codereview.chromium.org/925343003/diff/1/src/core/SkDevice.cpp File src/core/SkDevice.cpp (right): https://codereview.chromium.org/925343003/diff/1/src/core/SkDevice.cpp#newcode218 src/core/SkDevice.cpp:218: #include "SkTextToPathIter.h" On 2015/02/17 15:57:21, Hal Canary wrote: > ...
5 years, 10 months ago (2015-02-17 18:26:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925343003/20001
5 years, 10 months ago (2015-02-17 18:27:28 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/f87fe78bc36c94143625fc38cc848d0da86eb60d
5 years, 10 months ago (2015-02-17 18:33:59 UTC) #19
robertphillips
5 years, 10 months ago (2015-02-17 18:50:48 UTC) #20
Message was sent while issue was closed. 
Ooops - too late.

https://codereview.chromium.org/925343003/diff/20001/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/925343003/diff/20001/src/core/SkDevice.cpp#ne...
src/core/SkDevice.cpp:217: 
morph_points ?

https://codereview.chromium.org/925343003/diff/20001/src/core/SkDevice.cpp#ne...
src/core/SkDevice.cpp:255: */
morph_path ?

https://codereview.chromium.org/925343003/diff/20001/src/core/SkDevice.cpp#ne...
src/core/SkDevice.cpp:278: break;
kConic_Verb ?

Powered by Google App Engine
This is Rietveld 408576698