Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Issue 92533002: Add --open option to git cl issue. (Closed)

Created:
7 years ago by Lei Zhang
Modified:
7 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add git cl web command to open the current issue in the web browser. R=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238220

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M git_cl.py View 1 2 3 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
7 years ago (2013-11-27 20:12:29 UTC) #1
M-A Ruel
why not a new command "web" instead?
7 years ago (2013-11-27 20:20:02 UTC) #2
Lei Zhang
On 2013/11/27 20:20:02, M-A Ruel wrote: > why not a new command "web" instead? If ...
7 years ago (2013-11-27 21:59:20 UTC) #3
M-A Ruel
https://codereview.chromium.org/92533002/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/92533002/diff/20001/git_cl.py#newcode2156 git_cl.py:2156: return 0 Remove this line since it's not needed, ...
7 years ago (2013-12-02 21:57:57 UTC) #4
Lei Zhang
https://codereview.chromium.org/92533002/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/92533002/diff/20001/git_cl.py#newcode2156 git_cl.py:2156: return 0 On 2013/12/02 21:57:57, M-A Ruel wrote: > ...
7 years ago (2013-12-02 22:00:34 UTC) #5
M-A Ruel
lgtm, sorry for the delays. Feel free to ping after 12h.
7 years ago (2013-12-02 22:02:02 UTC) #6
Lei Zhang
7 years ago (2013-12-02 23:08:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r238220.

Powered by Google App Engine
This is Rietveld 408576698