A grab-bag of small improvements

1) Add 'to Google Drive' link to the all-backed-up message.
2) Don't show details header panel once user has completed import.
3) Introduce a local storage wrapper and make all existing importer uses of chrome.storage.local use this...much shorter and safer.
4) Auto-hide details panel when user clicks out.
5) Fix jank on the panel transition (and switch to vertical swoosh).

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Committed: https://crrev.com/8999968bbe5a44fe9e0ce92912e4201abc77ec5e
Cr-Commit-Position: refs/heads/master@{#316993}

[Steve McKay, 2015-02-18 20:04:49]

Actually do the banner hiding

[Steve McKay, 2015-02-18 20:05:09]

smckay@chromium.org changed reviewers:
+ hirono@chromium.org

[Steve McKay, 2015-02-19 00:40:53]

https://codereview.chromium.org/925233004/diff/60001/ui/file_manager/file_man...
File ui/file_manager/file_manager/background/js/task_queue.js (left):

https://codereview.chromium.org/925233004/diff/60001/ui/file_manager/file_man...
ui/file_manager/file_manager/background/js/task_queue.js:214: case
importer.TaskQueue.UpdateType.ERROR:
Note, that this UpdateType fires once for each error encountered during
processing. Since this resolves the finishedResolver, this was just an existing
error. Now fixed.

Folks interested in ERROR can add observers.

[Steve McKay, 2015-02-19 00:57:14]

Self review

[Steve McKay, 2015-02-19 01:01:20]

Don't change strings to something funny before hidding...our slow hide made them
visible for an instance.D

[Steve McKay, 2015-02-19 01:27:35]

Merge master

[hirono, 2015-02-19 04:55:09]

lgtm with comments. Thanks!

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:154: * @return
{!Promise} Resolves once the message has been handled.
nit: messing @param for message

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:159: 'Unrecognized
message type received from photos app: ' + message);
nit: indent should be 4 spaces.

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:740: *
nit: Please fix the indent.

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:771: *   no value
entry existis, or {@code undefined}.
nit: Indent should be 4 spaces

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/import_controller.js (right):

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:446:
'transitionend',
Please use ensureTransitionEndEvent. Sometimes transitionend is not dispatched
correctly.
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

[Steve McKay, 2015-02-19 05:14:43]

Thanks!

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:154: * @return
{!Promise} Resolves once the message has been handled.
On 2015/02/19 04:55:09, hirono wrote:
> nit: messing @param for message

Done.

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:159: 'Unrecognized
message type received from photos app: ' + message);
On 2015/02/19 04:55:09, hirono wrote:
> nit: indent should be 4 spaces.

Done.

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:740: *
On 2015/02/19 04:55:09, hirono wrote:
> nit: Please fix the indent.

Done.

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/importer_common.js:771: *   no value
entry existis, or {@code undefined}.
On 2015/02/19 04:55:09, hirono wrote:
> nit: Indent should be 4 spaces

Done.

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/import_controller.js (right):

https://codereview.chromium.org/925233004/diff/140001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/import_controller.js:446:
'transitionend',
On 2015/02/19 04:55:09, hirono wrote:
> Please use ensureTransitionEndEvent. Sometimes transitionend is not dispatched
> correctly.
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

Nice! Done.

[Steve McKay, 2015-02-19 05:14:52]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-02-19 05:15:07]

The CQ bit was unchecked by smckay@chromium.org

[Steve McKay, 2015-02-19 05:15:21]

New patchsets have been uploaded after l-g-t-m from hirono@chromium.org

[Steve McKay, 2015-02-19 05:15:23]

Respond to review comments.

[Steve McKay, 2015-02-19 05:15:31]

The CQ bit was checked by smckay@chromium.org

[commit-bot: I haz the power, 2015-02-19 05:15:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/925233004/160001

[commit-bot: I haz the power, 2015-02-19 05:47:25]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-02-19 05:48:01]

Patchset 9 (id:??) landed as
https://crrev.com/8999968bbe5a44fe9e0ce92912e4201abc77ec5e
Cr-Commit-Position: refs/heads/master@{#316993}