Issue 925043004: Update gyp file to reflect removed PartialPrivateScriptTest.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 925043004: Update gyp file to reflect removed PartialPrivateScriptTest.h (Closed)

Created:
5 years, 10 months ago by Daniel Bratell

Modified:
5 years, 10 months ago

Reviewers:
haraken, Jens Widell

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Update gyp file to reflect removed PartialPrivateScriptTest.h Source\core\testing\PartialPrivateScriptTest.h was removed in https://codereview.chromium.org/519703002 and this removed the file from the gypi file as well. This avoids warnings in the msvs-ninja gyp generator. R=haraken@chromium.org,jl@opera.com BUG=341031, 459058 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190663

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	Source/core/core.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (1 generated)

Jens Widell

On 2015/02/23 13:21:38, Jens Widell wrote: > LGTM But I'm not an owner, of course. ...

5 years, 10 months ago (2015-02-23 13:22:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925043004/1

5 years, 10 months ago (2015-02-23 14:06:44 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 15:26:31 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190663