Issue 9250017: Allow classes shadowed by type variables to be referenced in static context

Issue 9250017: Allow classes shadowed by type variables to be referenced in static context (Closed)

Created:
8 years, 11 months ago by zundel

Modified:
8 years, 11 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow classes shadowed by type variables to be referenced in static context We still print a shadowing warning, but if there is a valid reference outside the variable is now resolved to it. Otherwise, we print the existing message about not being able to reference type variables in a static context. See bug: http://code.google.com/p/dart/issues/detail?id=643 Committed: https://code.google.com/p/dart/source/detail?r=3434

Patch Set 1 : Updated copyright notices #

Patch Set 2 : Missed an error from negative resolver test, updated printing of assertions #

Patch Set 3 : oops, left bad test in. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -31 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java	View		3 chunks	+26 lines, -5 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/common/ErrorExpectation.java	View	1 2	2 chunks	+23 lines, -20 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View		2 chunks	+21 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/src/TypeVariableShadowsClass.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	tests/language/src/TypeVariableStaticContextNegativeTest.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zundel

Please take another look. I missed an error in NegativeResolverTest after fixing the top level ...

8 years, 11 months ago (2012-01-19 14:50:25 UTC) #3

zundel

That last trace didn't look good to me. I made a small change in patch ...

8 years, 11 months ago (2012-01-19 14:57:20 UTC) #4

That last trace didn't look good to me.  I made a small change in patch set 3

junit.framework.AssertionFailedError: Wrong number of errors encountered
Expected 7 errors
  DUPLICATE_TOP_LEVEL_DEFINITION (2,5/3)
  DUPLICATE_TOP_LEVEL_DEFINITION (4,7/3)
  DUPLICATE_TOP_LEVEL_DEFINITION (3,5/3)
  DUPLICATE_TOP_LEVEL_DEFINITION (5,7/3)
  DUPLICATE_MEMBER (2,5/3)
  DUPLICATE_MEMBER (5,7/3)
  DUPLICATE_MEMBER (3,5/3)
Encountered 8 errors
  DUPLICATE_TOP_LEVEL_DEFINITION (2,5/3): duplicate top-level definition 'foo'
  DUPLICATE_TOP_LEVEL_DEFINITION (4,7/3): duplicate top-level definition 'foo'
  DUPLICATE_TOP_LEVEL_DEFINITION (3,5/3): duplicate top-level definition 'bar'
  DUPLICATE_TOP_LEVEL_DEFINITION (5,7/3): duplicate top-level definition 'bar'
  DUPLICATE_MEMBER (4,7/3): Duplicate member 'foo'
  DUPLICATE_MEMBER (2,5/3): Duplicate member 'foo'
  DUPLICATE_MEMBER (5,7/3): Duplicate member 'bar'
  DUPLICATE_MEMBER (3,5/3): Duplicate member 'bar'

	at junit.framework.Assert.fail(Assert.java:47)
	at
com.google.dart.compiler.common.ErrorExpectation.assertErrors(ErrorExpectation.java:76)
	...


On 2012/01/19 14:50:25, zundel wrote:
> Please take another look.  I missed an error in NegativeResolverTest after
> fixing the top level scope issue in ResovlerTestCase.
> 
> The new error formatting looks like this:
> 
> 
> junit.framework.AssertionFailedError: Expected 4 errors, but got 8:
> [Test.dart(2:5): duplicate top-level definition 'foo', Test.dart(4:7):
duplicate
> top-level definition 'foo', Test.dart(3:5): duplicate top-level definition
> 'bar', Test.dart(5:7): duplicate top-level definition 'bar', Test.dart(4:7):
> Duplicate member 'foo', Test.dart(2:5): Duplicate member 'foo',
Test.dart(5:7):
> Duplicate member 'bar', Test.dart(3:5): Duplicate member 'bar']Expected 4
errors
>   DUPLICATE_TOP_LEVEL_DEFINITION (2,5/3)
>   DUPLICATE_TOP_LEVEL_DEFINITION (4,7/3)
>   DUPLICATE_TOP_LEVEL_DEFINITION (3,5/3)
>   DUPLICATE_TOP_LEVEL_DEFINITION (5,7/3)
> Encountered 8 errors
>   DUPLICATE_TOP_LEVEL_DEFINITION (2,5/3): duplicate top-level definition 'foo'
>   DUPLICATE_TOP_LEVEL_DEFINITION (4,7/3): duplicate top-level definition 'foo'
>   DUPLICATE_TOP_LEVEL_DEFINITION (3,5/3): duplicate top-level definition 'bar'
>   DUPLICATE_TOP_LEVEL_DEFINITION (5,7/3): duplicate top-level definition 'bar'
>   DUPLICATE_MEMBER (4,7/3): Duplicate member 'foo'
>   DUPLICATE_MEMBER (2,5/3): Duplicate member 'foo'
>   DUPLICATE_MEMBER (5,7/3): Duplicate member 'bar'
>   DUPLICATE_MEMBER (3,5/3): Duplicate member 'bar'
> 
> 	at junit.framework.Assert.fail(Assert.java:47)
> 	at
>
com.google.dart.compiler.common.ErrorExpectation.assertErrors(ErrorExpectation.java:76)
> 	at ...

LGTM

Expand Messages | Collapse Messages