Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3977)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 924973003: CC: Force push properties for all layers when tracing is started (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 68a1f587aa68dfaec95c50d9588beda55e2a9ac7..fd51fce34bb514333deab40a1fd4b70817e8d6a8 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -435,7 +435,7 @@ class LayerTreeHostTestSetNeedsRedrawRect : public LayerTreeHostTest {
}
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame_data,
+ FrameData* frame_data,
DrawResult draw_result) override {
EXPECT_EQ(DRAW_SUCCESS, draw_result);
@@ -619,7 +619,7 @@ class LayerTreeHostTestSetNextCommitForcesRedraw : public LayerTreeHostTest {
}
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame_data,
+ FrameData* frame_data,
DrawResult draw_result) override {
EXPECT_EQ(DRAW_SUCCESS, draw_result);
@@ -726,7 +726,7 @@ class LayerTreeHostTestUndrawnLayersDamageLater : public LayerTreeHostTest {
void BeginTest() override { PostSetNeedsCommitToMainThread(); }
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame_data,
+ FrameData* frame_data,
DrawResult draw_result) override {
EXPECT_EQ(DRAW_SUCCESS, draw_result);
@@ -1260,7 +1260,7 @@ class LayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers
EXPECT_EQ(gfx::Point(2, 2), child->position());
// Compute all the layer transforms for the frame.
- LayerTreeHostImpl::FrameData frame_data;
+ FrameData frame_data;
impl->PrepareToDraw(&frame_data);
impl->DidDrawAllLayers(frame_data);
@@ -2430,7 +2430,7 @@ class LayerTreeHostTestBeginFrameNotification : public LayerTreeHostTest {
}
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame,
+ FrameData* frame,
DrawResult draw_result) override {
EndTest();
return DRAW_SUCCESS;
@@ -2737,7 +2737,7 @@ class LayerTreeHostTestIOSurfaceDrawing : public LayerTreeHostTest {
}
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame,
+ FrameData* frame,
DrawResult draw_result) override {
Mock::VerifyAndClearExpectations(&mock_context_);
ResourceProvider* resource_provider = host_impl->resource_provider();
@@ -4074,7 +4074,7 @@ class LayerTreeHostTestTreeActivationCallback : public LayerTreeHostTest {
}
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame_data,
+ FrameData* frame_data,
DrawResult draw_result) override {
++num_commits_;
switch (num_commits_) {
@@ -5581,7 +5581,7 @@ class LayerTreeHostTestCrispUpAfterPinchEnds : public LayerTreeHostTest {
// Returns the delta scale of all quads in the frame's root pass from their
// ideal, or 0 if they are not all the same.
- float FrameQuadScaleDeltaFromIdeal(LayerTreeHostImpl::FrameData* frame_data) {
+ float FrameQuadScaleDeltaFromIdeal(FrameData* frame_data) {
if (frame_data->has_no_damage)
return 0.f;
float frame_scale = 0.f;
@@ -5606,7 +5606,7 @@ class LayerTreeHostTestCrispUpAfterPinchEnds : public LayerTreeHostTest {
void BeginTest() override { PostSetNeedsCommitToMainThread(); }
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame_data,
+ FrameData* frame_data,
DrawResult draw_result) override {
float quad_scale_delta = FrameQuadScaleDeltaFromIdeal(frame_data);
switch (frame_) {
@@ -5781,7 +5781,7 @@ class RasterizeWithGpuRasterizationCreatesResources : public LayerTreeHostTest {
void BeginTest() override { PostSetNeedsCommitToMainThread(); }
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame_data,
+ FrameData* frame_data,
DrawResult draw_result) override {
EXPECT_NE(0u, host_impl->resource_provider()->num_resources());
EndTest();
@@ -5826,7 +5826,7 @@ class SynchronousGpuRasterizationRasterizesVisibleOnly
void BeginTest() override { PostSetNeedsCommitToMainThread(); }
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame_data,
+ FrameData* frame_data,
DrawResult draw_result) override {
EXPECT_EQ(4u, host_impl->resource_provider()->num_resources());
@@ -5889,7 +5889,7 @@ class ThreadedGpuRasterizationRasterizesBorderTiles : public LayerTreeHostTest {
void BeginTest() override { PostSetNeedsCommitToMainThread(); }
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame_data,
+ FrameData* frame_data,
DrawResult draw_result) override {
EXPECT_EQ(10u, host_impl->resource_provider()->num_resources());
EndTest();
@@ -5950,7 +5950,7 @@ class LayerTreeHostTestContinuousDrawWhenCreatingVisibleTiles
// Returns the delta scale of all quads in the frame's root pass from their
// ideal, or 0 if they are not all the same.
- float FrameQuadScaleDeltaFromIdeal(LayerTreeHostImpl::FrameData* frame_data) {
+ float FrameQuadScaleDeltaFromIdeal(FrameData* frame_data) {
if (frame_data->has_no_damage)
return 0.f;
float frame_scale = 0.f;
@@ -5972,7 +5972,7 @@ class LayerTreeHostTestContinuousDrawWhenCreatingVisibleTiles
void BeginTest() override { PostSetNeedsCommitToMainThread(); }
DrawResult PrepareToDrawOnThread(LayerTreeHostImpl* host_impl,
- LayerTreeHostImpl::FrameData* frame_data,
+ FrameData* frame_data,
DrawResult draw_result) override {
float quad_scale_delta = FrameQuadScaleDeltaFromIdeal(frame_data);
switch (step_) {

Powered by Google App Engine
This is Rietveld 408576698