cc/layers/layer.cc - Issue 924973003: CC: Force push properties for all layers when tracing is started

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/layers/layer.cc

Issue 924973003: CC: Force push properties for all layers when tracing is started (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Introduce Layer::DidBeginTracing(), call SetNeedsPushProperties() from there Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2010 The Chromium Authors. All rights reserved.	1 // Copyright 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "cc/layers/layer.h"	5 #include "cc/layers/layer.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8	8

9 #include "base/atomic_sequence_num.h"	9 #include "base/atomic_sequence_num.h"

10 #include "base/location.h"	10 #include "base/location.h"

(...skipping 1331 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1342 return draw_opacity;	1342 return draw_opacity;

1343 }	1343 }

1344	1344

1345 void Layer::SetFrameTimingRequests(	1345 void Layer::SetFrameTimingRequests(

1346 const std::vector<FrameTimingRequest>& requests) {	1346 const std::vector<FrameTimingRequest>& requests) {

1347 frame_timing_requests_ = requests;	1347 frame_timing_requests_ = requests;

1348 frame_timing_requests_dirty_ = true;	1348 frame_timing_requests_dirty_ = true;

1349 SetNeedsCommit();	1349 SetNeedsCommit();

1350 }	1350 }

1351	1351

	1352 void Layer::DidBeginTracing() {

	1353 SetNeedsPushProperties();
	danakj 2015/03/06 18:50:12 Can you leave a comment explaining why we do SNPP( Can you leave a comment explaining why we do SNPP() here? basically what you've explained to me in the comments.
	1354 }

	1355

1352 } // namespace cc	1356 } // namespace cc

OLD	NEW

« no previous file with comments | « cc/layers/layer.h ('k') | cc/trees/layer_tree_host.cc » ('j') | cc/trees/layer_tree_host.cc » ('J')