Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 924953002: Fix ordering of FindByRoutingID parameters. (Closed)

Created:
5 years, 10 months ago by nasko
Modified:
5 years, 10 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ordering of FindByRoutingID parameters. Most callsites in Chrome use process id, routing id pair. FindByRoutingID has the parameters in reverse order leading to bugs. This CL fixes the ordering. BUG=454610 Committed: https://crrev.com/479ea5af28a7121022365384630634aa489ac916 Cr-Commit-Position: refs/heads/master@{#316336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/frame_host/frame_tree.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nasko
Hey Charlie, Can you review this CL for me? Thanks in advance! Nasko
5 years, 10 months ago (2015-02-13 22:47:21 UTC) #2
Charlie Reis
Only one call site? Nice. LGTM.
5 years, 10 months ago (2015-02-13 22:53:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924953002/1
5 years, 10 months ago (2015-02-13 22:57:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 00:03:15 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 00:04:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/479ea5af28a7121022365384630634aa489ac916
Cr-Commit-Position: refs/heads/master@{#316336}

Powered by Google App Engine
This is Rietveld 408576698