Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: Source/core/css/CSSFontFeatureValue.h

Issue 92493003: Have CSSFontFeatureValue store the tag as an AtomicString instead of a String (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add constructor argument names Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSFontFeatureValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 15 matching lines...) Expand all
26 #ifndef CSSFontFeatureValue_h 26 #ifndef CSSFontFeatureValue_h
27 #define CSSFontFeatureValue_h 27 #define CSSFontFeatureValue_h
28 28
29 #include "core/css/CSSValue.h" 29 #include "core/css/CSSValue.h"
30 #include "wtf/text/WTFString.h" 30 #include "wtf/text/WTFString.h"
31 31
32 namespace WebCore { 32 namespace WebCore {
33 33
34 class CSSFontFeatureValue : public CSSValue { 34 class CSSFontFeatureValue : public CSSValue {
35 public: 35 public:
36 static PassRefPtr<CSSFontFeatureValue> create(const String& tag, int value) 36 static PassRefPtr<CSSFontFeatureValue> create(const AtomicString& tag, int v alue)
37 { 37 {
38 return adoptRef(new CSSFontFeatureValue(tag, value)); 38 return adoptRef(new CSSFontFeatureValue(tag, value));
39 } 39 }
40 40
41 const String& tag() const { return m_tag; } 41 const AtomicString& tag() const { return m_tag; }
42 int value() const { return m_value; } 42 int value() const { return m_value; }
43 String customCSSText() const; 43 String customCSSText() const;
44 44
45 bool equals(const CSSFontFeatureValue&) const; 45 bool equals(const CSSFontFeatureValue&) const;
46 46
47 private: 47 private:
48 CSSFontFeatureValue(const String&, int); 48 CSSFontFeatureValue(const AtomicString& tag, int value);
49 49
50 String m_tag; 50 AtomicString m_tag;
51 const int m_value; 51 const int m_value;
52 }; 52 };
53 53
54 DEFINE_CSS_VALUE_TYPE_CASTS(CSSFontFeatureValue, isFontFeatureValue()); 54 DEFINE_CSS_VALUE_TYPE_CASTS(CSSFontFeatureValue, isFontFeatureValue());
55 55
56 } // namespace 56 } // namespace
57 57
58 #endif 58 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/CSSFontFeatureValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698