Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Side by Side Diff: Source/core/css/CSSFontFeatureValue.cpp

Issue 92493003: Have CSSFontFeatureValue store the tag as an AtomicString instead of a String (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 12 matching lines...) Expand all
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/css/CSSFontFeatureValue.h" 27 #include "core/css/CSSFontFeatureValue.h"
28 28
29 #include "wtf/text/StringBuilder.h" 29 #include "wtf/text/StringBuilder.h"
30 30
31 namespace WebCore { 31 namespace WebCore {
32 32
33 CSSFontFeatureValue::CSSFontFeatureValue(const String& tag, int value) 33 CSSFontFeatureValue::CSSFontFeatureValue(const AtomicString& tag, int value)
34 : CSSValue(FontFeatureClass) 34 : CSSValue(FontFeatureClass)
35 , m_tag(tag) 35 , m_tag(tag)
36 , m_value(value) 36 , m_value(value)
37 { 37 {
38 } 38 }
39 39
40 String CSSFontFeatureValue::customCSSText() const 40 String CSSFontFeatureValue::customCSSText() const
41 { 41 {
42 StringBuilder builder; 42 StringBuilder builder;
43 builder.append('\''); 43 builder.append('\'');
44 builder.append(m_tag); 44 builder.append(m_tag);
45 builder.appendLiteral("' "); 45 builder.appendLiteral("' ");
46 builder.appendNumber(m_value); 46 builder.appendNumber(m_value);
47 return builder.toString(); 47 return builder.toString();
48 } 48 }
49 49
50 bool CSSFontFeatureValue::equals(const CSSFontFeatureValue& other) const 50 bool CSSFontFeatureValue::equals(const CSSFontFeatureValue& other) const
51 { 51 {
52 return m_tag == other.m_tag && m_value == other.m_value; 52 return m_tag == other.m_tag && m_value == other.m_value;
53 } 53 }
54 54
55 } 55 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698