Add default options/suppressions for LeakSanitizer.

Add default options/suppressions for LeakSanitizer.

BUG=302040
R=glider@chromium.org

Committed: https://crrev.com/13a61c4c595371a3bb6286110e3c3f920818cbc2
Cr-Commit-Position: refs/heads/master@{#316480}

[earthdok, 2015-02-13 19:57:32]

ptal

[Alexander Potapenko, 2015-02-16 10:29:11]

LGTM with nits.
Please note your options/suppressions won't work with 32-bit CrOS builds.

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/lsan_su...
File build/sanitizers/lsan_suppressions.cc (right):

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/lsan_su...
build/sanitizers/lsan_suppressions.cc:13: // kTSanDefaultSuppressions contains
TSan suppressions delimited by newlines.
s/TSan/LSan
s/contains/that contains

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/lsan_su...
build/sanitizers/lsan_suppressions.cc:14: // See
http://dev.chromium.org/developers/testing/threadsanitizer-tsan-v2
Please fix the link

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/lsan_su...
build/sanitizers/lsan_suppressions.cc:17: // HeapCheck sanity test
This isn't a HeapCheck sanity test no more

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/sanitiz...
File build/sanitizers/sanitizer_options.cc (right):

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/sanitiz...
build/sanitizers/sanitizer_options.cc:156: __attribute__((no_sanitize_thread))
Did you mean __attribute__((no_sanitize_address)) ?

[earthdok, 2015-02-16 13:39:20]

New patchsets have been uploaded after l-g-t-m from glider@chromium.org

[earthdok, 2015-02-16 13:39:59]

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/lsan_su...
File build/sanitizers/lsan_suppressions.cc (right):

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/lsan_su...
build/sanitizers/lsan_suppressions.cc:13: // kTSanDefaultSuppressions contains
TSan suppressions delimited by newlines.
On 2015/02/16 10:29:11, Alexander Potapenko wrote:
> s/TSan/LSan
> s/contains/that contains

Done.

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/lsan_su...
build/sanitizers/lsan_suppressions.cc:14: // See
http://dev.chromium.org/developers/testing/threadsanitizer-tsan-v2
On 2015/02/16 10:29:11, Alexander Potapenko wrote:
> Please fix the link

Done.

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/lsan_su...
build/sanitizers/lsan_suppressions.cc:17: // HeapCheck sanity test
On 2015/02/16 10:29:11, Alexander Potapenko wrote:
> This isn't a HeapCheck sanity test no more

Done.

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/sanitiz...
File build/sanitizers/sanitizer_options.cc (right):

https://codereview.chromium.org/924923002/diff/80001/build/sanitizers/sanitiz...
build/sanitizers/sanitizer_options.cc:156: __attribute__((no_sanitize_thread))
On 2015/02/16 10:29:11, Alexander Potapenko wrote:
> Did you mean __attribute__((no_sanitize_address)) ?

I've refactored this file a bit, ptal.

[Alexander Potapenko, 2015-02-16 13:41:42]

lgtm

[earthdok, 2015-02-16 13:42:44]

The CQ bit was checked by earthdok@chromium.org

[commit-bot: I haz the power, 2015-02-16 13:42:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/924923002/100001

[commit-bot: I haz the power, 2015-02-16 14:43:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-16 14:44:08]

Patchset 6 (id:??) landed as
https://crrev.com/13a61c4c595371a3bb6286110e3c3f920818cbc2
Cr-Commit-Position: refs/heads/master@{#316480}