IndexedDB: Replace custom binding logic with [SetWrapperReferenceTo]

Source/bindings/modules/v8/IDBBindingUtilities.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 98 matching lines @@
     if (!impl)
         return v8::Null(isolate);
 
     switch (impl->type()) {
     case IDBAny::UndefinedType:
         return v8::Undefined(isolate);
     case IDBAny::NullType:
         return v8::Null(isolate);
     case IDBAny::DOMStringListType:
         return toV8(impl->domStringList(), creationContext, isolate);
-    case IDBAny::IDBCursorType: {
-        // Ensure request wrapper is kept alive at least as long as the cursor wrapper,
-        // so that event listeners are retained.
-        v8::Local<v8::Value> cursor = toV8(impl->idbCursor(), creationContext, isolate);
-        v8::Local<v8::Value> request = toV8(impl->idbCursor()->request(), creationContext, isolate);
-
-        // FIXME: Due to race at worker shutdown, V8 may return empty handles.

[jsbell, 2015/02/13 19:28:00]

Hopefully we're already handling this in the generated code...

-        if (!cursor.IsEmpty())
-            V8HiddenValue::setHiddenValue(isolate, cursor->ToObject(isolate), V8HiddenValue::idbCursorRequest(isolate), request);
-        return cursor;
-    }
-    case IDBAny::IDBCursorWithValueType: {
-        // Ensure request wrapper is kept alive at least as long as the cursor wrapper,
-        // so that event listeners are retained.
-        v8::Local<v8::Value> cursor = toV8(impl->idbCursorWithValue(), creationContext, isolate);
-        v8::Local<v8::Value> request = toV8(impl->idbCursorWithValue()->request(), creationContext, isolate);
-
-        // FIXME: Due to race at worker shutdown, V8 may return empty handles.
-        if (!cursor.IsEmpty())
-            V8HiddenValue::setHiddenValue(isolate, cursor->ToObject(isolate), V8HiddenValue::idbCursorRequest(isolate), request);
-        return cursor;
-    }
+    case IDBAny::IDBCursorType:
+        return toV8(impl->idbCursor(), creationContext, isolate);
+    case IDBAny::IDBCursorWithValueType:
+        return toV8(impl->idbCursorWithValue(), creationContext, isolate);
     case IDBAny::IDBDatabaseType:
         return toV8(impl->idbDatabase(), creationContext, isolate);
     case IDBAny::IDBIndexType:
         return toV8(impl->idbIndex(), creationContext, isolate);
     case IDBAny::IDBObjectStoreType:
         return toV8(impl->idbObjectStore(), creationContext, isolate);
     case IDBAny::BufferType:
         return deserializeIDBValueBuffer(isolate, impl->buffer(), impl->blobInfo());
     case IDBAny::IntegerType:
         return v8::Number::New(isolate, impl->integer());
@@ skipping 307 matching lines @@
     const bool allowExperimentalTypes = true;
     IDBKey* expectedKey = createIDBKeyFromScriptValueAndKeyPathInternal(isolate, scriptValue, keyPath, allowExperimentalTypes);
     ASSERT(!expectedKey || expectedKey->isEqual(key));
 
     bool injected = injectV8KeyIntoV8Value(isolate, keyValue.v8Value(), scriptValue.v8Value(), keyPath);
     ASSERT_UNUSED(injected, injected);
 }
 #endif
 
 } // namespace blink