Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: content/browser/accessibility/accessibility_ui.cc

Issue 924843002: Fix for possible crashes due to pointer value being null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/accessibility_ui.cc
diff --git a/content/browser/accessibility/accessibility_ui.cc b/content/browser/accessibility/accessibility_ui.cc
index a8a5d97ad3ef62bb594ccc8cc7ea395fcb373f80..3bfa6ee62b2bf4c2fd9583cdc318fd4db989dbba 100644
--- a/content/browser/accessibility/accessibility_ui.cc
+++ b/content/browser/accessibility/accessibility_ui.cc
@@ -66,7 +66,7 @@ base::DictionaryValue* BuildTargetDescriptor(
base::DictionaryValue* BuildTargetDescriptor(RenderViewHost* rvh) {
WebContentsImpl* web_contents = static_cast<WebContentsImpl*>(
WebContents::FromRenderViewHost(rvh));
- AccessibilityMode accessibility_mode = web_contents->GetAccessibilityMode();
+ AccessibilityMode accessibility_mode = AccessibilityModeOff;
std::string title;
GURL url;
@@ -80,6 +80,7 @@ base::DictionaryValue* BuildTargetDescriptor(RenderViewHost* rvh) {
NavigationEntry* entry = controller.GetVisibleEntry();
if (entry != NULL && entry->GetURL().is_valid())
favicon_url = entry->GetFavicon().url;
+ accessibility_mode = web_contents->GetAccessibilityMode();
}
return BuildTargetDescriptor(url,
« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698