Fix for possible crashes due to pointer value being null

content/common/cursors/webcursor.cc

Index: content/common/cursors/webcursor.cc
diff --git a/content/common/cursors/webcursor.cc b/content/common/cursors/webcursor.cc
index 85721fdd0e2bae52ef010ff19ae60df6eb764d36..b9ab178543e47273bc8d80189d97698e73eb3ef5 100644
--- a/content/common/cursors/webcursor.cc
+++ b/content/common/cursors/webcursor.cc
@@ -142,8 +142,10 @@ bool WebCursor::Serialize(Pickle* pickle) const {
     return false;
 
   const char* data = NULL;
-  if (!custom_data_.empty())
-    data = &custom_data_[0];
+  if (custom_data_.empty())
+    return false;

[Charlie Reis, 2015/02/17 21:26:59]

This is probably the wrong thing to do.  It's probably legitimate to have an
empty custom_data_, in which case we would write 0 bytes and move on
successfully.  There's no reason to abort early here with a return false.

Are you sure there's even a bug here?  Writing 0 bytes may mean that we don't
touch |data| at all, so it might not matter that it's NULL.  (In fact, it looks
like WriteData may put that 0 into the format, so it matters that we make that
call.)

[Sunil Ratnu, 2015/02/18 09:04:45]

Removed this change as we do not need to abort early.

+
+  data = &custom_data_[0];
   if (!pickle->WriteData(data, custom_data_.size()))
     return false;