Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 92483002: Remove Chrome Frame tests from lkgr finder and gatekeeper. (Closed)

Created:
7 years ago by grt (UTC plus 2)
Modified:
7 years ago
Reviewers:
cmp, iannucci, robertshield
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove Chrome Frame tests from lkgr finder and gatekeeper. BUG=316496 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=237835

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M build/masters/master.chromium.win/master_gatekeeper_cfg.py View 1 chunk +0 lines, -4 lines 0 comments Download
M build/masters/master.chromium.win/master_win_cfg.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/scripts/tools/lkgr_finder.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
Hi Robbie and Robert, First commit to drop CF. I figure it makes sense to ...
7 years ago (2013-11-27 20:03:49 UTC) #1
robertshield
lgtm, godspeed
7 years ago (2013-11-27 20:06:04 UTC) #2
cmp
OK, great patch, and it's close, but don't land this as-is. The first step will ...
7 years ago (2013-11-27 21:11:15 UTC) #3
grt (UTC plus 2)
Thanks for the detailed info, Chase. I've moved the CQ portion into https://codereview.chromium.org/93563002/ and the ...
7 years ago (2013-11-28 02:30:29 UTC) #4
cmp
lgtm
7 years ago (2013-11-28 19:56:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/92483002/20001
7 years ago (2013-11-28 20:36:45 UTC) #6
commit-bot: I haz the power
7 years ago (2013-11-28 20:37:53 UTC) #7
Message was sent while issue was closed.
Change committed as 237835

Powered by Google App Engine
This is Rietveld 408576698