Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 924823002: Refactored the final parts of the TurboFan pipeline a bit. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactored the final parts of the TurboFan pipeline a bit. This removed some inconsistent/duplicated code and made the testing side entrance much simpler: Now it simply constructs a pipeline and hands off to the "tail" of the normal pipeline. R=danno@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/e9fd6b083625c8bc253013dd4eda82be81673204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -64 lines) Patch
M src/compiler/pipeline.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 7 chunks +44 lines, -63 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sven Panne
5 years, 10 months ago (2015-02-13 09:56:06 UTC) #2
danno
lgtm
5 years, 10 months ago (2015-02-13 10:00:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924823002/1
5 years, 10 months ago (2015-02-13 10:08:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2984)
5 years, 10 months ago (2015-02-13 10:11:58 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e9fd6b083625c8bc253013dd4eda82be81673204 Cr-Commit-Position: refs/heads/master@{#26637}
5 years, 10 months ago (2015-02-13 10:35:43 UTC) #8
Sven Panne
5 years, 10 months ago (2015-02-13 10:35:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e9fd6b083625c8bc253013dd4eda82be81673204 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698