Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/testing/dart/summary_report.dart

Issue 924793002: Add SkipSlow marker (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests/language/assert_with_type_test_or_cast_test.dart ('K') | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/summary_report.dart
diff --git a/tools/testing/dart/summary_report.dart b/tools/testing/dart/summary_report.dart
index d6db9a97680a81fadf9f84e4c052f2c194ecfdfb..2f740b52c1995b72a906bbb0ac8c11a10d5afd94 100644
--- a/tools/testing/dart/summary_report.dart
+++ b/tools/testing/dart/summary_report.dart
@@ -36,7 +36,8 @@ class SummaryReport {
bool containsFail = expectations
.any((expectation) => expectation.canBeOutcomeOf(Expectation.FAIL));
bool containsPass = expectations.contains(Expectation.PASS);
- bool containsSkip = expectations.contains(Expectation.SKIP);
+ bool containsSkip = expectations
+ .any((expectation) => expectation.canBeOutcomeOf(Expectation.SKIP));
bool containsSkipByDesign =
expectations.contains(Expectation.SKIP_BY_DESIGN);
bool containsCrash = expectations.contains(Expectation.CRASH);
« tests/language/assert_with_type_test_or_cast_test.dart ('K') | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698