Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 924783003: Prepare for moving nacl_irt_icache definition to the NaCl repository. (Closed)

Created:
5 years, 10 months ago by mazda
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare for moving nacl_irt_icache definition to the NaCl repository. Once nacl_irt_icache has been included in irt.h in the NaCl repository, Chrome build would fail due to multiple definition error. This is a change for preparing for the NaCl roll that includes the NaCl side change. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4033 Committed: https://crrev.com/8ec0c5c4b02b77ca5df6e8c79173901c4a94d568 Cr-Commit-Position: refs/heads/master@{#316461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ppapi/nacl_irt/public/irt_nonsfi.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mazda
mseaborn@: Could you review the CL? dmichael@: Could you do an OWNERS review? Thanks,
5 years, 10 months ago (2015-02-13 10:17:36 UTC) #2
Mark Seaborn
LGTM
5 years, 10 months ago (2015-02-13 16:16:32 UTC) #3
dmichael (off chromium)
lgtm
5 years, 10 months ago (2015-02-13 16:32:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924783003/1
5 years, 10 months ago (2015-02-16 11:37:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 12:42:36 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 12:43:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ec0c5c4b02b77ca5df6e8c79173901c4a94d568
Cr-Commit-Position: refs/heads/master@{#316461}

Powered by Google App Engine
This is Rietveld 408576698