Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 924783002: options: fix guest mode showing advanced settings bug. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
Reviewers:
Mike Lerman
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

options: fix guest mode showing advanced settings bug. R=mlerman@chromium.org BUG=457255 Committed: https://crrev.com/a49a521c100bb5cd44962f99b5a4e6bc45dbe95f Cr-Commit-Position: refs/heads/master@{#316323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mike Lerman
Seems logical to me LGTM
5 years, 10 months ago (2015-02-13 13:46:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924783002/1
5 years, 10 months ago (2015-02-13 22:42:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 23:28:10 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 23:30:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a49a521c100bb5cd44962f99b5a4e6bc45dbe95f
Cr-Commit-Position: refs/heads/master@{#316323}

Powered by Google App Engine
This is Rietveld 408576698