Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/gfx/render_text.h

Issue 924773002: Fix multiline behaviors for RTL text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/render_text_harfbuzz.h » ('j') | ui/gfx/render_text_harfbuzz.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.h
diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h
index 6c094dcc36d51c6e29574aeedcedb47376a3a38c..e3ec24c21fac25eea6163b00494366896a53c6f0 100644
--- a/ui/gfx/render_text.h
+++ b/ui/gfx/render_text.h
@@ -45,10 +45,10 @@ class RenderTextTest;
namespace internal {
// Internal helper class used by derived classes to draw text through Skia.
-class SkiaTextRenderer {
+class GFX_EXPORT SkiaTextRenderer {
public:
explicit SkiaTextRenderer(Canvas* canvas);
- ~SkiaTextRenderer();
+ virtual ~SkiaTextRenderer();
void SetDrawLooper(SkDrawLooper* draw_looper);
void SetFontRenderParams(const FontRenderParams& params,
@@ -63,14 +63,14 @@ class SkiaTextRenderer {
// two metrics must be set together.
void SetUnderlineMetrics(SkScalar thickness, SkScalar position);
void DrawSelection(const std::vector<Rect>& selection, SkColor color);
- void DrawPosText(const SkPoint* pos,
- const uint16* glyphs,
- size_t glyph_count);
+ virtual void DrawPosText(const SkPoint* pos,
+ const uint16* glyphs,
+ size_t glyph_count);
// Draw underline and strike-through text decorations.
// Based on |SkCanvas::DrawTextDecorations()| and constants from:
// third_party/skia/src/core/SkTextFormatParams.h
- void DrawDecorations(int x, int y, int width, bool underline, bool strike,
- bool diagonal_strike);
+ virtual void DrawDecorations(int x, int y, int width, bool underline,
+ bool strike, bool diagonal_strike);
// Finishes any ongoing diagonal strike run.
void EndDiagonalStrike();
void DrawUnderline(int x, int y, int width);
« no previous file with comments | « no previous file | ui/gfx/render_text_harfbuzz.h » ('j') | ui/gfx/render_text_harfbuzz.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698