Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 924743002: Re-sort GYP files with the latest version of tools/source_list.py (Closed)

Created:
5 years, 10 months ago by satorux1
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, eroman, jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, Dai Mikurube (NOT FULLTIME), wfh+watch_chromium.org, jam, darin-cc_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-sort GYP files with the latest version of tools/source_list.py In crrev.com/316164, a bug was fixed to handle comments in a source list correctly. In this patch, a bug was fixed to handle comments at the end of a source list. Along the way, sort some GYP files in sub directories under base and net, which I forgot to sort previously. BUG=456014 TEST=everything should build as before Committed: https://crrev.com/eef164ef753ccb97ae45d6c86e12a3f2c3318d1d Cr-Commit-Position: refs/heads/master@{#316418}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : run the script again #

Total comments: 1

Patch Set 4 : Fix a typo introduced recently #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -66 lines) Patch
M base/allocator/allocator.gyp View 5 chunks +7 lines, -7 lines 0 comments Download
M base/third_party/dynamic_annotations/dynamic_annotations.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_debugger.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_exe.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 4 chunks +6 lines, -6 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M content/content_tests.gypi View 1 6 chunks +21 lines, -21 lines 0 comments Download
M net/net.gyp View 1 chunk +4 lines, -4 lines 0 comments Download
M net/net.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
M net/third_party/nss/ssl.gyp View 3 chunks +2 lines, -2 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/sort_sources.py View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
satorux1
Sorry to bother you again. Hope this is the last iteration for updating major GYP ...
5 years, 10 months ago (2015-02-13 05:24:33 UTC) #2
eroman
lgtm
5 years, 10 months ago (2015-02-13 06:04:10 UTC) #3
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-13 07:03:24 UTC) #4
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-13 07:04:57 UTC) #5
jam
lgtm
5 years, 10 months ago (2015-02-13 16:54:43 UTC) #6
satorux1
https://codereview.chromium.org/924743002/diff/40001/content/content_browser.gypi File content/content_browser.gypi (right): https://codereview.chromium.org/924743002/diff/40001/content/content_browser.gypi#newcode262 content/content_browser.gypi:262: 'public_browser/tracing_delegate.h', this must be a typo introduced in c563c582a ...
5 years, 10 months ago (2015-02-16 00:36:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924743002/60001
5 years, 10 months ago (2015-02-16 00:38:14 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-16 01:39:41 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 01:40:27 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/eef164ef753ccb97ae45d6c86e12a3f2c3318d1d
Cr-Commit-Position: refs/heads/master@{#316418}

Powered by Google App Engine
This is Rietveld 408576698