chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 924733003: Credential Manager API pops up an auto-signin toast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 924733003: Credential Manager API pops up an auto-signin toast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc ('k') | chrome/browser/ui/views/passwords/credentials_item_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index c98b5e55deb1c2d7f8f2a70457c23eb031cf1fd6..b6eeaefc8266a12250ed5b063ecbec6b427855aa 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -392,6 +392,10 @@ void ManagePasswordsUIController::ShowBubbleWithoutUserInteraction() {

Browser* browser = chrome::FindBrowserWithWebContents(web_contents());

if (!browser || browser->toolbar_model()->input_in_progress())

return;

+ if (state_ == password_manager::ui::PENDING_PASSWORD_STATE &&

+ !password_bubble_experiment::ShouldShowBubble(

+ browser->profile()->GetPrefs()))

+ return;

CommandUpdater* updater = browser->command_controller()->command_updater();

updater->ExecuteCommand(IDC_MANAGE_PASSWORDS_FOR_PAGE);

#endif