components/password_manager/core/browser/password_manager_metrics_util.h - Issue 924733003: Credential Manager API pops up an auto-signin toast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 924733003: Credential Manager API pops up an auto-signin toast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_metrics_util.h

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h

index d4ea6c33237ac76ff68b8d3f57b8c2bc52bd4ee6..9fae408cce03290d301c7cd95a20f55c84860b46 100644

--- a/components/password_manager/core/browser/password_manager_metrics_util.h

+++ b/components/password_manager/core/browser/password_manager_metrics_util.h

@@ -30,6 +30,7 @@ enum UIDisplayDisposition {

MANUAL_BLACKLISTED,

AUTOMATIC_GENERATED_PASSWORD_CONFIRMATION,

AUTOMATIC_CREDENTIAL_REQUEST,

+ AUTOMATIC_AUTO_SIGNIN_TOAST,

NUM_DISPLAY_DISPOSITIONS

};

@@ -48,6 +49,7 @@ enum UIDismissalReason {

CLICKED_CREDENTIAL,

CLICKED_COLLECT_URL,

CLICKED_DO_NOT_COLLECT_URL,

+ AUTO_SIGNIN_TOAST_TIMEOUT,

NUM_UI_RESPONSES,

// If we add the omnibox icon _without_ intending to display the bubble,