Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: snapshot/module_snapshot.h

Issue 924673003: Add MinidumpCrashpadInfo::simple_annotations (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/mac/process_snapshot_mac.cc ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/module_snapshot.h
diff --git a/snapshot/module_snapshot.h b/snapshot/module_snapshot.h
index ef2a9c1f0c485d8b6f9b8004fb7233f05662c4ca..d8f1ae6bd92f81a00b54dde1d2707eb228ee5564 100644
--- a/snapshot/module_snapshot.h
+++ b/snapshot/module_snapshot.h
@@ -142,10 +142,14 @@ class ModuleSnapshot {
//!
//! For Mac OS X snapshots, these annotations are found by interpreting the
//! `__DATA, __crashpad_info` section as `CrashpadInfo`. Clients can use the
- //! Crashpad client interface to store annotations in this structure.
+ //! Crashpad client interface to store annotations in this structure. Most
+ //! annotations under the client’s direct control will be retrievable by this
+ //! method. For clients such as Chrome, this includes the process type.
//!
//! The annotations returned by this method do not duplicate those returned by
- //! AnnotationsVector().
+ //! AnnotationsVector(). Additional annotations related to the process,
+ //! system, or snapshot producer may be obtained by calling
+ //! ProcessSnapshot::AnnotationsSimpleMap().
virtual std::map<std::string, std::string> AnnotationsSimpleMap() const = 0;
};
« no previous file with comments | « snapshot/mac/process_snapshot_mac.cc ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698