Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: minidump/minidump_crashpad_info_writer.h

Issue 924673003: Add MinidumpCrashpadInfo::simple_annotations (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | minidump/minidump_crashpad_info_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_crashpad_info_writer.h
diff --git a/minidump/minidump_crashpad_info_writer.h b/minidump/minidump_crashpad_info_writer.h
index 22c60747af7271fa4785b91ea14dfc8fe2a81b93..1ef3a8015e308824e3d839edcd62ba9a835a054f 100644
--- a/minidump/minidump_crashpad_info_writer.h
+++ b/minidump/minidump_crashpad_info_writer.h
@@ -25,6 +25,7 @@
namespace crashpad {
class MinidumpModuleCrashpadInfoListWriter;
+class MinidumpSimpleStringDictionaryWriter;
class ProcessSnapshot;
//! \brief The writer for a MinidumpCrashpadInfo stream in a minidump file.
@@ -50,6 +51,17 @@ class MinidumpCrashpadInfoWriter final : public internal::MinidumpStreamWriter {
//! methods after this method.
void InitializeFromSnapshot(const ProcessSnapshot* process_snapshot);
+ //! \brief Arranges for MinidumpCrashpadInfo::simple_annotations to point to
+ //! the MinidumpSimpleStringDictionaryWriter object to be written by \a
+ //! simple_annotations.
+ //!
+ //! This object takes ownership of \a simple_annotations and becomes its
+ //! parent in the overall tree of internal::MinidumpWritable objects.
+ //!
+ //! \note Valid in #kStateMutable.
+ void SetSimpleAnnotations(
+ scoped_ptr<MinidumpSimpleStringDictionaryWriter> simple_annotations);
+
//! \brief Arranges for MinidumpCrashpadInfo::module_list to point to the
//! MinidumpModuleCrashpadInfoList object to be written by \a
//! module_list.
@@ -82,6 +94,7 @@ class MinidumpCrashpadInfoWriter final : public internal::MinidumpStreamWriter {
private:
MinidumpCrashpadInfo crashpad_info_;
+ scoped_ptr<MinidumpSimpleStringDictionaryWriter> simple_annotations_;
scoped_ptr<MinidumpModuleCrashpadInfoListWriter> module_list_;
DISALLOW_COPY_AND_ASSIGN(MinidumpCrashpadInfoWriter);
« no previous file with comments | « no previous file | minidump/minidump_crashpad_info_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698