Add MinidumpCrashpadInfo::simple_annotations

snapshot/process_snapshot.h

Index: snapshot/process_snapshot.h
diff --git a/snapshot/process_snapshot.h b/snapshot/process_snapshot.h
index 3fe317fa1f5517b082ccdabeb0a819833412d429..8352e4c26abda95162494a6f42d0b880cea611da 100644
--- a/snapshot/process_snapshot.h
+++ b/snapshot/process_snapshot.h
@@ -18,6 +18,8 @@
 #include <sys/time.h>
 #include <sys/types.h>
 
+#include <map>
+#include <string>
 #include <vector>
 
 namespace crashpad {
@@ -75,6 +77,24 @@ class ProcessSnapshot {
   virtual void ProcessCPUTimes(timeval* user_time,
                                timeval* system_time) const = 0;
 
+  //! \brief Returns key-value string annotations recorded for the process,
+  //!     system, or snapshot producer.
+  //!
+  //! This method retrieves annotations recorded for a process. These
+  //! annotations are intended for diagnostic use, including crash analysis.
+  //! “Simple annotations” are structured as a sequence of key-value pairs,
+  //! where all keys and values are strings. These are referred to in Chrome as
+  //! “crash keys.”
+  //!
+  //! Annotations stored here may reflect the process, system, or snapshot
+  //! producer. Most annotations not under the client’s direct control will be
+  //! retrievable by this method. For clients such as Chrome, this includes the
+  //! product name and version.
+  //!
+  //! Additional per-module annotations may be obtained by calling
+  //! ModuleSnapshot::AnnotationsSimpleMap().
+  virtual std::map<std::string, std::string> AnnotationsSimpleMap() const = 0;

[Robert Sesek, 2015/02/17 22:20:35]

This could be a const& instead, since the objects returned by the other methods
here are guaranteed to be owned by the snapshot.

[Mark Mentovai, 2015/02/17 22:22:01]

Robert Sesek wrote:
Is it fair to impose that at the interface level, though? Or just let it stand
for now and drop it if it becomes a problem in the future?

[Robert Sesek, 2015/02/17 22:23:14]

I don't feel strongly, but the copy seems like it could be heavy, and it's
unnecessary with the current implementations. All the other objects returned off
this interface are const*, though.

+
   //! \brief Returns a SystemSnapshot reflecting the characteristics of the
   //!     system that ran the snapshot process at the time of the snapshot.
   //!