Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 924653002: Use StrongBinding instead of InterfaceImpl in wm event dispatcher (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use StrongBinding instead of InterfaceImpl in wm event dispatcher R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/05d5629855e68bf1ba55a0ec969e43575c04adca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M services/window_manager/native_viewport_event_dispatcher_impl.h View 3 chunks +6 lines, -2 lines 0 comments Download
M services/window_manager/native_viewport_event_dispatcher_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/window_manager/window_manager_app.h View 3 chunks +6 lines, -4 lines 0 comments Download
M services/window_manager/window_manager_app.cc View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
5 years, 10 months ago (2015-02-19 00:55:35 UTC) #1
sky
LGTM
5 years, 10 months ago (2015-02-19 01:34:28 UTC) #2
jamesr
5 years, 10 months ago (2015-02-19 01:35:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
05d5629855e68bf1ba55a0ec969e43575c04adca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698