Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: extensions/browser/updater/safe_manifest_parser.h

Issue 924603003: Remove ManifestFetchData parameter from SafeManifestParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merged latest from origin/master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/updater/safe_manifest_parser.h
diff --git a/extensions/browser/updater/safe_manifest_parser.h b/extensions/browser/updater/safe_manifest_parser.h
index 3215fa316e8ba68553d56cd5489d0aff02652200..9f31ab64a5a7de0d7377f5914bda6bdd5c28147c 100644
--- a/extensions/browser/updater/safe_manifest_parser.h
+++ b/extensions/browser/updater/safe_manifest_parser.h
@@ -20,13 +20,10 @@ namespace extensions {
class SafeManifestParser : public content::UtilityProcessHostClient {
public:
// Callback that is invoked when the manifest results are ready.
- typedef base::Callback<void(const ManifestFetchData&,
- const UpdateManifest::Results*)> UpdateCallback;
+ typedef base::Callback<void(const UpdateManifest::Results*)> ResultsCallback;
- // Takes ownership of |fetch_data|.
SafeManifestParser(const std::string& xml,
- ManifestFetchData* fetch_data,
- const UpdateCallback& update_callback);
+ const ResultsCallback& results_callback);
// Posts a task over to the IO loop to start the parsing of xml_ in a
// utility process.
@@ -47,8 +44,7 @@ class SafeManifestParser : public content::UtilityProcessHostClient {
const std::string xml_;
// Should be accessed only on UI thread.
- scoped_ptr<ManifestFetchData> fetch_data_;
- UpdateCallback update_callback_;
+ ResultsCallback results_callback_;
DISALLOW_COPY_AND_ASSIGN(SafeManifestParser);
};
« no previous file with comments | « extensions/browser/updater/extension_downloader.cc ('k') | extensions/browser/updater/safe_manifest_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698