Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 924603003: Remove ManifestFetchData parameter from SafeManifestParser (Closed)

Created:
5 years, 10 months ago by asargent_no_longer_on_chrome
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ManifestFetchData parameter from SafeManifestParser All it was doing with it is passing it through to its completion callback (apart from 2 VLOG statements). This CL changes to binding it to the callback directly with the base::Bind call. Also rename UpdateCallback to ResultsCallback, because that seemed like a better name to me. And run our autoformatting thing As Required By Law. BUG=458373 Committed: https://crrev.com/d71a7a6b1d878a5c0077863e03b6f12eabaee2b7 Cr-Commit-Position: refs/heads/master@{#316342}

Patch Set 1 #

Patch Set 2 : fix unit test to pass ptr instead of ref #

Patch Set 3 : move log statement above return to eliminate uncreachable code error #

Patch Set 4 : merged latest from origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -34 lines) Patch
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/extension_downloader.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 1 2 3 chunks +17 lines, -18 lines 0 comments Download
M extensions/browser/updater/safe_manifest_parser.h View 2 chunks +3 lines, -7 lines 0 comments Download
M extensions/browser/updater/safe_manifest_parser.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
asargent_no_longer_on_chrome
This is a small chunk of refactoring I broke out of a larger CL I'm ...
5 years, 10 months ago (2015-02-13 01:04:11 UTC) #2
Marijn Kruisselbrink
lgtm
5 years, 10 months ago (2015-02-13 17:16:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924603003/1
5 years, 10 months ago (2015-02-13 17:26:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/8124)
5 years, 10 months ago (2015-02-13 17:38:12 UTC) #7
asargent_no_longer_on_chrome
Missed a conversation from const ref to const pointer in a unit test file ; ...
5 years, 10 months ago (2015-02-13 17:48:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924603003/20001
5 years, 10 months ago (2015-02-13 17:49:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24904)
5 years, 10 months ago (2015-02-13 18:53:48 UTC) #13
asargent_no_longer_on_chrome
new version uploaded which moves VLOG statement above return to eliminate unreachable code error
5 years, 10 months ago (2015-02-13 19:16:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924603003/60001
5 years, 10 months ago (2015-02-13 23:47:08 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-14 00:32:08 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 00:32:42 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d71a7a6b1d878a5c0077863e03b6f12eabaee2b7
Cr-Commit-Position: refs/heads/master@{#316342}

Powered by Google App Engine
This is Rietveld 408576698