Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 924593002: Merge the tonic layer from skydart branch back to master (Closed)

Created:
5 years, 10 months ago by rafaelw
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Merge the tonic layer from skydart branch back to master The tonic layer is analogous to "gin" for v8. It provides wrappers and helpers around common dart types and implements the basic infrastructure for allowing dart wrappers around sky DOM objects to have proper GC behavior. R=abarth@chromium.org TBR=eseidel BUG= Committed: https://chromium.googlesource.com/external/mojo/+/f89a3f477277280366cebe334972e09fbb78fd48

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1622 lines, -10 lines) Patch
A sky/engine/tonic/BUILD.gn View 1 chunk +49 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_api_scope.h View 1 chunk +24 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_builtin.h View 1 chunk +39 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_builtin.cc View 1 chunk +50 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_class_library.h View 1 chunk +33 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_class_library.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_class_provider.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + sky/engine/tonic/dart_class_provider.cc View 1 chunk +5 lines, -6 lines 0 comments Download
A sky/engine/tonic/dart_converter.h View 1 chunk +325 lines, -0 lines 0 comments Download
A + sky/engine/tonic/dart_converter.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A sky/engine/tonic/dart_error.h View 1 chunk +21 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_error.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_gc_context.h View 1 chunk +31 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_gc_context.cc View 1 chunk +28 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_gc_controller.h View 1 chunk +15 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_gc_controller.cc View 1 chunk +48 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_gc_visitor.h View 1 chunk +39 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_gc_visitor.cc View 1 chunk +26 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_isolate_scope.h View 1 chunk +28 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_isolate_scope.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_persistent_value.h View 1 chunk +43 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_persistent_value.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_state.h View 1 chunk +62 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_state.cc View 1 chunk +42 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_string.h View 1 chunk +19 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_string.cc View 1 chunk +65 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_string_cache.h View 1 chunk +48 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_string_cache.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_value.h View 1 chunk +59 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_value.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_wrappable.h View 1 chunk +141 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_wrappable.cc View 1 chunk +91 lines, -0 lines 0 comments Download
A sky/engine/tonic/dart_wrapper_info.h View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rafaelw
5 years, 10 months ago (2015-02-12 19:27:51 UTC) #2
abarth-chromium
LGTM
5 years, 10 months ago (2015-02-12 20:53:47 UTC) #3
rafaelw
5 years, 10 months ago (2015-02-12 20:55:12 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f89a3f477277280366cebe334972e09fbb78fd48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698