Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: ui/gfx/render_text_unittest.cc

Issue 924543004: adding baseline options for super/sub scripting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change for Win XP unittest Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_unittest.cc
diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc
index 2233c31e045773ed21d425b6d590d29ca3d9aa28..e8ff23d6598c4796910dd52c5aae78d3f8aeafaf 100644
--- a/ui/gfx/render_text_unittest.cc
+++ b/ui/gfx/render_text_unittest.cc
@@ -2713,8 +2713,11 @@ TEST_F(RenderTextTest, TextDoesntClip) {
}
{
SCOPED_TRACE("TextDoesntClip Left Side");
-#if defined(OS_WIN) || defined(OS_MACOSX)
- // TODO(mukai): On Windows and Mac smoothing draws left of text.
+#if defined(OS_WIN)
+ // TODO(mukai): On Windows XP the Unicode test draws to the left edge as
+ // if it is ignoring the SetDisplayRect shift by kTestSize.
+#elif defined(OS_MACOSX)
+ // TODO(mukai): On Windows (non-XP) and Mac smoothing draws left of text.
rect_buffer.EnsureSolidRect(SK_ColorWHITE, 0, kTestSize, kTestSize - 1,
string_size.height());
#else
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698