ui/gfx/render_text_mac.cc - Issue 924543004: adding baseline options for super/sub scripting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_mac.cc

Issue 924543004: adding baseline options for super/sub scripting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed debug prints; cleaned up comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/render_text_mac.cc

diff --git a/ui/gfx/render_text_mac.cc b/ui/gfx/render_text_mac.cc

index 1c046648dc63220fcca566f1ec8c85a106cd3d5e..0fee832b2496b1e55f289ef6d0bf424837a64d35 100644

--- a/ui/gfx/render_text_mac.cc

+++ b/ui/gfx/render_text_mac.cc

@@ -230,7 +230,7 @@ void RenderTextMac::ApplyStyles(CFMutableAttributedStringRef attr_string,

attributes_.reset(CFArrayCreateMutable(NULL, 0, &kCFTypeArrayCallBacks));

// https://developer.apple.com/library/mac/#documentation/Carbon/Reference/CoreText_StringAttributes_Ref/Reference/reference.html

- internal::StyleIterator style(colors(), styles());

+ internal::StyleIterator style(colors(), baselines(), styles());

const size_t layout_text_length = GetDisplayText().length();

for (size_t i = 0, end = 0; i < layout_text_length; i = end) {

end = TextIndexToDisplayIndex(style.GetRange().end());