adding baseline options for super/sub scripting

ui/gfx/render_text.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_RENDER_TEXT_H_
 #define UI_GFX_RENDER_TEXT_H_
 
 #include <algorithm>
 #include <cstring>
 #include <string>
@@ skipping 91 matching lines @@
   Canvas* canvas_;
   SkCanvas* canvas_skia_;
   SkPaint paint_;
   SkScalar underline_thickness_;
   SkScalar underline_position_;
   scoped_ptr<DiagonalStrike> diagonal_;
 
   DISALLOW_COPY_AND_ASSIGN(SkiaTextRenderer);
 };
 
 // Internal helper class used by derived classes to iterate colors and styles.

[msw, 2015/02/18 17:07:23]

nit: // Internal helper class used to iterate colors, baselines, and styles.

[dschuyler, 2015/02/18 22:36:02]

Done.

 class StyleIterator {
  public:
   StyleIterator(const BreakList<SkColor>& colors,
+                const BreakList<BaselineStyle>& baselines,
                 const std::vector<BreakList<bool> >& styles);
   ~StyleIterator();
 
   // Get the colors and styles at the current iterator position.
   SkColor color() const { return color_->second; }
+  BaselineStyle baseline() const { return (BaselineStyle)baseline_->second; }

[msw, 2015/02/18 17:07:23]

nit: is the cast needed? if so, use static_cast instead of a C-style cast.

[dschuyler, 2015/02/18 22:36:02]

Done.

   bool style(TextStyle s) const { return style_[s]->second; }
 
   // Get the intersecting range of the current iterator set.
   Range GetRange() const;
 
   // Update the iterator to point to colors and styles applicable at |position|.
   void UpdatePosition(size_t position);
 
  private:
   BreakList<SkColor> colors_;
+  BreakList<BaselineStyle> baselines_;
   std::vector<BreakList<bool> > styles_;
 
   BreakList<SkColor>::const_iterator color_;
+  BreakList<BaselineStyle>::const_iterator baseline_;
   std::vector<BreakList<bool>::const_iterator> style_;
 
   DISALLOW_COPY_AND_ASSIGN(StyleIterator);
 };
 
 // Line segments are slices of the layout text to be rendered on a single line.
 struct LineSegment {
   LineSegment();
   ~LineSegment();
 
@@ skipping 185 matching lines @@
   void SelectWord();
 
   const Range& GetCompositionRange() const;
   void SetCompositionRange(const Range& composition_range);
 
   // Set the text color over the entire text or a logical character range.
   // The |range| should be valid, non-reversed, and within [0, text().length()].
   void SetColor(SkColor value);
   void ApplyColor(SkColor value, const Range& range);
 
+  // Set the text baseline style over the entire text or a logical character

[msw, 2015/02/18 17:07:23]

nit: remove "text" for cleaner comment wrapping.

[dschuyler, 2015/02/18 22:36:02]

Done.

+  // range.  The |range| should be valid, non-reversed, and within
+  // [0, text().length()].
+  void SetBaselineStyle(BaselineStyle value);
+  void ApplyBaselineStyle(BaselineStyle value, const Range& range);
+
   // Set various text styles over the entire text or a logical character range.
   // The respective |style| is applied if |value| is true, or removed if false.
   // The |range| should be valid, non-reversed, and within [0, text().length()].
   void SetStyle(TextStyle style, bool value);
   void ApplyStyle(TextStyle style, bool value, const Range& range);
 
   // Returns whether this style is enabled consistently across the entire
   // RenderText.
   bool GetStyle(TextStyle style) const;
 
@@ skipping 93 matching lines @@
   // Rect can't have a negative width.)
   virtual Range GetGlyphBounds(size_t index) = 0;
 
   const Vector2d& GetUpdatedDisplayOffset();
   void SetDisplayOffset(int horizontal_offset);
 
  protected:
   RenderText();
 
   const BreakList<SkColor>& colors() const { return colors_; }
+  const BreakList<BaselineStyle>& baselines() const { return baselines_; }
   const std::vector<BreakList<bool> >& styles() const { return styles_; }
 
   const std::vector<internal::Line>& lines() const { return lines_; }
   void set_lines(std::vector<internal::Line>* lines) { lines_.swap(*lines); }
 
   // Returns the baseline of the current text.  The return value depends on
   // the text and its layout while the return value of GetBaseline() doesn't.
   // GetAlignmentOffset() takes into account the difference between them.
   //
   // We'd like a RenderText to show the text always on the same baseline
@@ skipping 203 matching lines @@
 
   // The background color used for drawing the selection when focused.
   SkColor selection_background_focused_color_;
 
   // The focus state of the text.
   bool focused_;
 
   // Composition text range.
   Range composition_range_;
 
   // Color and style breaks, used to color and stylize ranges of text.

[msw, 2015/02/18 17:07:23]

nit: "// Color, baseline, and style breaks, used to modify ranges of text."

[dschuyler, 2015/02/18 22:36:02]

Done.

   // BreakList positions are stored with text indices, not layout indices.
   // TODO(msw): Expand to support cursor, selection, background, etc. colors.
   BreakList<SkColor> colors_;
+  BreakList<BaselineStyle> baselines_;
   std::vector<BreakList<bool> > styles_;
 
   // Breaks saved without temporary composition and selection styling.
   BreakList<SkColor> saved_colors_;
   BreakList<bool> saved_underlines_;
   bool composition_and_selection_styles_applied_;
 
   // A flag to obscure actual text with asterisks for password fields.
   bool obscured_;
   // The index at which the char should be revealed in the obscured text.
@@ skipping 52 matching lines @@
   // Lines computed by EnsureLayout. These should be invalidated with
   // ResetLayout and on |display_rect_| changes.
   std::vector<internal::Line> lines_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderText);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_RENDER_TEXT_H_