Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 924543003: Avoid InterfaceImpl in //services/test_service (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -17 lines) Patch
M services/test_service/test_request_tracker_application.h View 2 chunks +6 lines, -5 lines 0 comments Download
M services/test_service/test_request_tracker_application.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M services/test_service/test_request_tracker_impl.h View 2 chunks +6 lines, -3 lines 0 comments Download
M services/test_service/test_request_tracker_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/test_service/test_service_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/test_service/test_service_impl.h View 2 chunks +8 lines, -3 lines 0 comments Download
M services/test_service/test_service_impl.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
5 years, 10 months ago (2015-02-12 20:52:30 UTC) #1
viettrungluu
lgtm
5 years, 10 months ago (2015-02-12 20:59:12 UTC) #2
jamesr
5 years, 10 months ago (2015-02-12 21:02:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab60bd378b4d9622a3500e635ceaf44ebb3ed8c0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698