Source/platform/graphics/paint/DisplayItemList.cpp - Issue 924533006: Don't remove empty display item pairs that draw content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/paint/DisplayItemList.cpp

Issue 924533006: Don't remove empty display item pairs that draw content (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/paint/DisplayItemList.cpp

diff --git a/Source/platform/graphics/paint/DisplayItemList.cpp b/Source/platform/graphics/paint/DisplayItemList.cpp

index 1f0cae0f6bf8ffd1975f0fa30997742b05d4d9e0..fec0fe1dd15942eac4fe5af295f4f2beff742ea9 100644

--- a/Source/platform/graphics/paint/DisplayItemList.cpp

+++ b/Source/platform/graphics/paint/DisplayItemList.cpp

@@ -28,7 +28,7 @@ void DisplayItemList::add(WTF::PassOwnPtr<DisplayItem> displayItem)

if (displayItem->isEnd()) {

ASSERT(!m_newPaints.isEmpty());

- if (m_newPaints.last()->isBegin()) {

+ if (m_newPaints.last()->isBegin() && !m_newPaints.last()->drawsContent()) {

ASSERT(displayItem->isEndAndPairedWith(*m_newPaints.last()));

// Remove the beginning display item of this empty pair.

m_newPaints.removeLast();