Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: Source/platform/graphics/paint/DisplayItem.h

Issue 924533006: Don't remove empty display item pairs that draw content (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DisplayItem_h 5 #ifndef DisplayItem_h
6 #define DisplayItem_h 6 #define DisplayItem_h
7 7
8 #include "platform/PlatformExport.h" 8 #include "platform/PlatformExport.h"
9 #include "platform/graphics/paint/DisplayItemClient.h" 9 #include "platform/graphics/paint/DisplayItemClient.h"
10 #include "wtf/Assertions.h" 10 #include "wtf/Assertions.h"
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 DEFINE_CONVERSION_METHODS(SubtreeCached, subtreeCached, EndSubtree, endSubtr ee) 227 DEFINE_CONVERSION_METHODS(SubtreeCached, subtreeCached, EndSubtree, endSubtr ee)
228 DEFINE_CONVERSION_METHODS(BeginSubtree, beginSubtree, EndSubtree, endSubtree ) 228 DEFINE_CONVERSION_METHODS(BeginSubtree, beginSubtree, EndSubtree, endSubtree )
229 229
230 virtual bool isBegin() const { return false; } 230 virtual bool isBegin() const { return false; }
231 virtual bool isEnd() const { return false; } 231 virtual bool isEnd() const { return false; }
232 232
233 #if ENABLE(ASSERT) 233 #if ENABLE(ASSERT)
234 virtual bool isEndAndPairedWith(const DisplayItem& other) const { return fal se; } 234 virtual bool isEndAndPairedWith(const DisplayItem& other) const { return fal se; }
235 #endif 235 #endif
236 236
237 virtual bool drawsContent() const { return false; }
238
237 #ifndef NDEBUG 239 #ifndef NDEBUG
238 static WTF::String typeAsDebugString(DisplayItem::Type); 240 static WTF::String typeAsDebugString(DisplayItem::Type);
239 241
240 void setClientDebugString(const WTF::String& clientDebugString) { m_clientDe bugString = clientDebugString; } 242 void setClientDebugString(const WTF::String& clientDebugString) { m_clientDe bugString = clientDebugString; }
241 const WTF::String& clientDebugString() const { return m_clientDebugString; } 243 const WTF::String& clientDebugString() const { return m_clientDebugString; }
242 244
243 WTF::String asDebugString() const; 245 WTF::String asDebugString() const;
244 virtual void dumpPropertiesAsDebugString(WTF::StringBuilder&) const; 246 virtual void dumpPropertiesAsDebugString(WTF::StringBuilder&) const;
245 #endif 247 #endif
246 248
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 virtual bool isEndAndPairedWith(const DisplayItem& other) const override = 0 ; 284 virtual bool isEndAndPairedWith(const DisplayItem& other) const override = 0 ;
283 #endif 285 #endif
284 286
285 private: 287 private:
286 virtual bool isEnd() const override final { return true; } 288 virtual bool isEnd() const override final { return true; }
287 }; 289 };
288 290
289 } // namespace blink 291 } // namespace blink
290 292
291 #endif // DisplayItem_h 293 #endif // DisplayItem_h
OLDNEW
« no previous file with comments | « LayoutTests/css3/filters/empty-element-with-filter-expected.html ('k') | Source/platform/graphics/paint/DisplayItemList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698