LayoutTests/css3/filters/empty-element-with-filter-expected.html - Issue 924533006: Don't remove empty display item pairs that draw content

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/filters/empty-element-with-filter-expected.html

Issue 924533006: Don't remove empty display item pairs that draw content (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/css3/filters/empty-element-with-filter.html ('k') | Source/platform/graphics/paint/DisplayItem.h » ('j') | Source/platform/graphics/paint/DrawingDisplayItem.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #turbulent {

	4 width: 160px;

	5 height: 90px;

	6 -webkit-filter: url(#turbulence);

	7 filter: url(#turbulence);

	8

	9 /* Make the div have visible content without the filter. */
	Stephen Chennney 2015/02/19 16:13:27 This comment confused me, but that's because the t This comment confused me, but that's because the term "expected" is not really describing the test. Really it is "these 2 things should be the same" I would prefer a test that alone, without the expected result, showed the right/wrong behavior. That is, two divs in the same document, one with content and one without, that should look the same. The reference would then have the same 2 divs, both with content (or you could be tricky and switch the content/no-content rect in the expected). ajuma 2015/02/19 17:36:51 Done. Show quoted text On 2015/02/19 16:13:27, Stephen Chenney wrote: > This comment confused me, but that's because the term "expected" is not really > describing the test. Really it is "these 2 things should be the same" > > I would prefer a test that alone, without the expected result, showed the > right/wrong behavior. That is, two divs in the same document, one with content > and one without, that should look the same. The reference would then have the > same 2 divs, both with content (or you could be tricky and switch the > content/no-content rect in the expected). Done.
	10 background-color: red;

	11 }

	12 </style>

	13 <div id="turbulent"></div>

	14

	15 This test ensures we properly render filters on elements that otherwise have

	16 no visible content.

	17

	18 <svg xmlns="http://www.w3.org/2000/svg" width="0" height="0" version="1.1">

	19 <defs>

	20 <filter id="turbulence" color-interpolation-filters="sRGB">

	21 <feTurbulence type="turbulence" baseFrequency="0.05" numOctaves="2"/>

	22 </filter>

	23 </defs>

	24 </svg>

OLD	NEW