[PDF] Fixes the cases where SkPDFDevice::finishContentEntry is called with empty content.

[PDF] Fixes the cases where SkPDFDevice::finishContentEntry is called with empty content.

There are some cases (like drawing a completely transparent image) where the code tries to finish a content entry with no content and an xfermode other than clear.  This makes those cases work correctly.

This is likely what was happening in chromium:316546, but it wasn't clear what the core problem was. desk_techcrunch.skp tripped a debug only assert that exposed the core issue.

BUG=skia:1868, chromium:316546
Committed: http://code.google.com/p/skia/source/detail?r=12473

[reed1, 2013-11-27 20:08:41]

Thanks for starting on this.

Looks like a bit of code. Can we write a test(s) that trips this code-path,
other than that picture (which may change the next rev of chrome)?

[vandebo (ex-Chrome), 2013-11-27 22:33:59]

On 2013/11/27 20:08:41, reed1 wrote:
> Thanks for starting on this.
> 
> Looks like a bit of code. Can we write a test(s) that trips this code-path,
> other than that picture (which may change the next rev of chrome)?

Modified a gm to exercise the code path, which turned up a related issue that I
also fixed.

[vandebo (ex-Chrome), 2013-12-03 15:59:42]

ping

[bungeman-skia, 2013-12-03 16:11:43]

lgtm

You may wish to update the description to BUG=skia:1868. Not sure that rietveld
does the right thing, but it would make it clearer.

[commit-bot: I haz the power, 2013-12-03 20:48:09]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/92453002/20001

[commit-bot: I haz the power, 2013-12-03 20:48:12]

Failed to apply patch for expectations/gm/ignored-tests.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file expectations/gm/ignored-tests.txt
  Hunk #1 FAILED at 45.
  1 out of 1 hunk FAILED -- saving rejects to file
expectations/gm/ignored-tests.txt.rej

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
cf3d60083553fdae31e3877239c48a0f466f1e2f..407c1bf93011e0075b91d370bfca4025bc16edec
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -45,3 +45,6 @@ perlinnoise
 
 # Added by bsalomon in support of adding HQ filter to GPU device drawBitmap
 bleed
+
+# Added by vandebo in https://codereview.chromium.org/92453002/
+xfermodes

[commit-bot: I haz the power, 2013-12-03 20:56:09]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/92453002/40001

[commit-bot: I haz the power, 2013-12-03 21:08:48]

Change committed as 12473