tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py - Issue 924513004: Revert of Revert of [Telemtry] Move url lists of alexa1-10000 page to a json file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

Issue 924513004: Revert of Revert of [Telemtry] Move url lists of alexa1-10000 page to a json file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

diff --git a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

index 9410166e585dd3a93c2044730b173754c9cef410..bf63d94370516d4de4f59909fe9d365b39a14725 100644

--- a/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

+++ b/tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py

@@ -103,7 +103,7 @@

def CheckAttributesOfPageBasicAttributes(self, page):

self.assertTrue(not hasattr(page, 'disabled'))

self.assertTrue(

- isinstance(page.url, str),

+ isinstance(page.url, basestring),

msg='page %s \'s url must have type string' % page.display_name)

self.assertTrue(

isinstance(page.page_set, page_set_module.PageSet),

« no previous file with comments | « tools/perf/page_sets/alexa1-10000-urls.json ('k') | no next file » | no next file with comments »