Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 924453002: Fix invalid use of int in Zone. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix invalid use of int in Zone. Committed: https://crrev.com/4465836c8a615ed6c15c8d80bb414ce8d9f0624c Cr-Commit-Position: refs/heads/master@{#26609}

Patch Set 1 #

Patch Set 2 : Make Windows happy #

Patch Set 3 : Next windows fix... #

Patch Set 4 : Windows again... #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -89 lines) Patch
M src/ast.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node-cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/register-allocator-verifier.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/scheduler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/value-numbering-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 2 3 3 chunks +4 lines, -6 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M src/lithium-allocator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/lithium-allocator.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/typing.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/zone.h View 6 chunks +19 lines, -26 lines 0 comments Download
M src/zone.cc View 11 chunks +23 lines, -26 lines 1 comment Download
M test/unittests/compiler/zone-pool-unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Benedikt Meurer
No more static_cast<int> for zone allocations! PTAL
5 years, 10 months ago (2015-02-12 11:28:07 UTC) #2
Sven Panne
lgtm
5 years, 10 months ago (2015-02-12 11:50:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924453002/20001
5 years, 10 months ago (2015-02-12 11:50:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/1908)
5 years, 10 months ago (2015-02-12 12:10:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924453002/60001
5 years, 10 months ago (2015-02-12 12:16:49 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-12 12:47:04 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/4465836c8a615ed6c15c8d80bb414ce8d9f0624c Cr-Commit-Position: refs/heads/master@{#26609}
5 years, 10 months ago (2015-02-12 12:47:37 UTC) #12
Jakob Kummerow
4 years, 7 months ago (2016-04-28 12:16:14 UTC) #14
Message was sent while issue was closed. 
https://codereview.chromium.org/924453002/diff/60001/src/zone.cc
File src/zone.cc (right):

https://codereview.chromium.org/924453002/diff/60001/src/zone.cc#newcode108
src/zone.cc:108: if (limit_ < position_ + size_with_redzone) {
This is not just a cosmetic change! The addition can overflow
(crbug.com/606115), the old code used subtraction intentionally!

Powered by Google App Engine
This is Rietveld 408576698