IDL: Support iterable<>/maplike<>/setlike<> referencing typedefs

IDL: Support iterable<>/maplike<>/setlike<> referencing typedefs

The types referenced by iterable<>, maplike<> and setlike<> definitions
were not subject to typedef resolution, leading to incorrect code
generation.

In the process, slightly generalize the typedef resolution mechanism to
support objects referencing more than one type, as iterable<> and
maplike<> definitions do.

BUG=432683
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190052

[Jens Widell, 2015-02-12 11:12:50]

jl@opera.com changed reviewers:
+ bashi@chromium.org, haraken@chromium.org

[Jens Widell, 2015-02-12 11:12:51]

PTAL

[bashi, 2015-02-12 12:36:19]

Thank you for the fix! LGTM.

https://codereview.chromium.org/924443002/diff/20001/Source/bindings/scripts/...
File Source/bindings/scripts/idl_definitions.py (right):

https://codereview.chromium.org/924443002/diff/20001/Source/bindings/scripts/...
Source/bindings/scripts/idl_definitions.py:329: if self.iterable:
Question: Could a dictionary have a member which is an iterable? Same for
maplike and setlike.

[haraken, 2015-02-12 12:41:03]

LGTM

[Jens Widell, 2015-02-12 12:47:51]

https://codereview.chromium.org/924443002/diff/20001/Source/bindings/scripts/...
File Source/bindings/scripts/idl_definitions.py (right):

https://codereview.chromium.org/924443002/diff/20001/Source/bindings/scripts/...
Source/bindings/scripts/idl_definitions.py:329: if self.iterable:
On 2015/02/12 12:36:19, bashi1 wrote:
> Question: Could a dictionary have a member which is an iterable? Same for
> maplike and setlike.

You can't have

  dictionary Foo {
    iterable<DOMString>;
  };

if that's what you mean. Only interfaces can have these declarations.

[Jens Widell, 2015-02-12 12:47:55]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2015-02-12 12:48:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/924443002/20001

[bashi, 2015-02-12 13:08:19]

https://codereview.chromium.org/924443002/diff/20001/Source/bindings/scripts/...
File Source/bindings/scripts/idl_definitions.py (right):

https://codereview.chromium.org/924443002/diff/20001/Source/bindings/scripts/...
Source/bindings/scripts/idl_definitions.py:329: if self.iterable:
On 2015/02/12 12:47:51, Jens Widell wrote:
> On 2015/02/12 12:36:19, bashi1 wrote:
> > Question: Could a dictionary have a member which is an iterable? Same for
> > maplike and setlike.
> 
> You can't have
> 
>   dictionary Foo {
>     iterable<DOMString>;
>   };
> 
> if that's what you mean. Only interfaces can have these declarations.

Oops, I just overlooked collapsed lines (L219-L318). I thought that line 329-334
were added in IdlDictionaryMember.accept(). Sorry for the noise.

[commit-bot: I haz the power, 2015-02-12 14:03:13]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190052