tools/perf/measurements/v8_gc_times.py - Issue 924433004: [telemetry]: Add idle% measurement unit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/v8_gc_times.py

Issue 924433004: [telemetry]: Add idle% measurement unit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/v8_gc_times.py

diff --git a/tools/perf/measurements/v8_gc_times.py b/tools/perf/measurements/v8_gc_times.py

index 9715c423dfcf8f700855a19a9431a201670e7be7..330939494d30bcbda7ce997d5dac28541728d852 100644

--- a/tools/perf/measurements/v8_gc_times.py

+++ b/tools/perf/measurements/v8_gc_times.py

@@ -109,7 +109,7 @@ class V8GCTimes(page_test.PageTest):

('Total idle task deadline overrun for %s idle tasks'

% v8_event_stat.result_description)))

results.AddValue(scalar.ScalarValue(results.current_page,

- '%s_percentage_idle' % v8_event_stat.result_name, '%',

+ '%s_percentage_idle' % v8_event_stat.result_name, 'idle%',

v8_event_stat.percentage_thread_duration_during_idle,

('Percentage of %s spent in idle time' %

v8_event_stat.result_description)))

@@ -136,7 +136,7 @@ class V8GCTimes(page_test.PageTest):

'Total idle task deadline overrun for all idle tasks garbage '

'collection events'))

results.AddValue(scalar.ScalarValue(results.current_page,

- 'v8_gc_total_percentage_idle', '%', gc_total_percentage_idle,

+ 'v8_gc_total_percentage_idle', 'idle%', gc_total_percentage_idle,

'Percentage of the thread duration of all garbage collection events '

'spent inside of idle tasks'))

« no previous file with comments | « no previous file | tools/perf/measurements/v8_gc_times_unittest.py » ('j') | no next file with comments »