Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: net/cert/ct_verifier.h

Issue 92443002: Extract Certificate Transparency SCTs from stapled OCSP responses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extract_scts
Patch Set: Fix C++11 compile error Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/ct_objects_extractor_unittest.cc ('k') | net/cert/multi_log_ct_verifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_verifier.h
diff --git a/net/cert/ct_verifier.h b/net/cert/ct_verifier.h
index 5a6868680c01b09dcab19fe368cb882f27f449a4..290a0474a649138733c902fdc5a8e47b6210f12d 100644
--- a/net/cert/ct_verifier.h
+++ b/net/cert/ct_verifier.h
@@ -21,12 +21,18 @@ class NET_EXPORT CTVerifier {
public:
virtual ~CTVerifier() {}
- // Verifies either embedded SCTs or SCTs obtained via the
- // signed_certificate_timestamp TLS extension or OCSP on the given |cert|
- // |result| will be filled with these SCTs, divided into categories based on
- // the verification result.
+ // Verifies SCTs embedded in the certificate itself, SCTs embedded in a
+ // stapled OCSP response, and SCTs obtained via the
+ // signed_certificate_timestamp TLS extension on the given |cert|.
+ // A certificate is permitted but not required to use multiple sources for
+ // SCTs. It is expected that most certificates will use only one source
+ // (embedding, TLS extension or OCSP stapling). If no stapled OCSP response
+ // is available, |stapled_ocsp_response| should be an empty string. If no SCT
+ // TLS extension was negotiated, |sct_list_from_tls_extension| should be an
+ // empty string. |result| will be filled with the SCTs present, divided into
+ // categories based on the verification result.
virtual int Verify(X509Certificate* cert,
- const std::string& sct_list_from_ocsp,
+ const std::string& stapled_ocsp_response,
const std::string& sct_list_from_tls_extension,
ct::CTVerifyResult* result,
const BoundNetLog& net_log) = 0;
« no previous file with comments | « net/cert/ct_objects_extractor_unittest.cc ('k') | net/cert/multi_log_ct_verifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698